feat: Add retry support in Action postprocessor #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update enhances the Composio toolset by introducing retry support in the Action postprocessor. A new Changes
🔗 Related PRs
InstructionsEmoji Descriptions:
Interact with the Bot:
Execute a command using the format:
Available Commands:
Tips for Using @bot Effectively:
Need More Help?📚 Visit our documentation for detailed guides on using Entelligence.AI. |
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
Comment on lines
649
to
655
| key: _KeyType, | ||
| data: t.Dict, | ||
| type_: te.Literal["pre", "post", "schema"], | ||
| ) -> t.Dict: | ||
| ) -> t.Union[t.Dict, _Retry]: | ||
| processor = self._get_processor(key=key, type_=type_) | ||
| if processor is not None: | ||
| self.logger.info( |
There was a problem hiding this comment.
🤖 Bug Fix:
Ensure Compatibility with New Return Type
The change in the return type from t.Dict to t.Union[t.Dict, _Retry] is significant and requires careful handling to avoid runtime errors.
- Review Calling Code: Ensure all parts of the codebase that call this function are updated to handle both
t.Dictand_Retrytypes appropriately. - Update Documentation: Reflect the new return type in the function's documentation to inform other developers of the change.
- Enhance Testing: Add or update tests to cover scenarios where
_Retryis returned, ensuring robust handling of this type.
This change is critical and should be managed with thorough testing and documentation updates to prevent logical errors. 🛠️
| "Received RETRY from App schema processor function." | ||
| " Schema pprocessors cannot be retried." | ||
| ) | ||
| assert not isinstance(processed, _Retry) |
There was a problem hiding this comment.
Suggested change
| assert not isinstance(processed, _Retry) |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3939a0d in 10 minutes and 19 seconds
More details
- Looked at
238lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. python/composio/tools/toolset.py:724
- Draft comment:
Typo in error message: 'pprocessors' should be 'processors'. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a retry mechanism for action postprocessors. However, there is a typo in the error message for schema processors that should be corrected.
2. python/composio/tools/toolset.py:736
- Draft comment:
Typo in error message: 'preprocessor' should be 'schema processor'. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a retry mechanism for action postprocessors. However, there is a typo in the error message for schema processors that should be corrected.
3. python/composio/tools/toolset.py:694
- Draft comment:
Typo in function name: '_process_respone' should be '_process_response'. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a retry mechanism for action postprocessors. However, there is a typo in the error message for schema processors that should be corrected.
Workflow ID: wflow_RgJp76D74M3IviRL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Review Summary
Purpose
Introduce retry support in the Action postprocessor to enhance the Composio toolset.
Key Changes
New Feature
_Retryclass andmax_retriesparameter toComposioToolSetconstructor.Enhancement
ComposioToolSetto incorporate retry logic.Documentation
RETRYto import list and__all__declaration in__init__.pyfiles.Impact
Improves error handling and resilience in Composio toolset by allowing retry attempts in the Action postprocessor, enhancing overall user experience.
Original Description
No existing description found