-
Notifications
You must be signed in to change notification settings - Fork 743
Fix file_groupowner_etc_chrony_keys OVAL check #13248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file_groupowner_etc_chrony_keys OVAL check #13248
Conversation
Hi @svet-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test scenario covering the situation that is fixed by this PR.
Hey @jan-cerny, |
- add tests scpecific for file_groupowner_etc_chrony_keys rule as they require chrony package - add a test for the change introduced in ComplianceAsCode#13248 so we will test also locked groups
Code Climate has analyzed commit e0e1124 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 62.0% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the tests!
jcerny@fedora:~/work/git/scap-security-guide (pr/13248)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 file_groupowner_etc_chrony_keys
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-04-01-0850/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_file_groupowner_etc_chrony_keys
INFO - Script correct_chrony_keys_groupowner.pass.sh using profile (all) OK
INFO - Script correct_chrony_keys_locked_groupowner.pass.sh using profile (all) OK
INFO - Script incorrect_chrony_keys_groupowner.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/13248)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible file_groupowner_etc_chrony_keys
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-04-01-0853/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_file_groupowner_etc_chrony_keys
INFO - Script correct_chrony_keys_groupowner.pass.sh using profile (all) OK
INFO - Script correct_chrony_keys_locked_groupowner.pass.sh using profile (all) OK
INFO - Script incorrect_chrony_keys_groupowner.fail.sh using profile (all) OK
Description:
Rationale: