Sno feat node delete button #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove beta. * Only show node versions with certain statuses. * Add accept or reject node page for admins. * Add admin home page. * Refetch on actions. * Show status reason. * remove github icon * Add total results. * Add Download numbers * Add delete modal. * Show download numbers. * Fixed: drawer did not open on non publisher node. * Don't retry on 404 queries. * Fix margin on search results. * Remove redundant call to listAllNodes. * Use node icon. * feat(search-node-name): add comfy_nodes and description to (#27) * feat(search-node-name): add comfy_nodes and description to add comfy_nodes and description to search results * fix(search-hit): count matched count matched * Improve mobile CSS. * Update fonts. * fix(sno-fix-total-install): meta info pretty (#28) * fix(sno-fix-gray-bg): fix gray bg (#29) fix gray bg --------- Co-authored-by: Robin Huang <[email protected]> Co-authored-by: Yoland Y <[email protected]>
onclose
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…feat-node-delete-button
remove console
nodedetails solve conflict
says node deleted
go to /nodes after deletion success
robinjhuang
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow publisher to delete uploaded node with confirmation.
Feat Confirmation:
export ENVIRONMENT=staging comfy node publishGoto node page
https://staging.comfyregistry.org/publishers/snomiao-test/nodes/node-registry-test
Click delete confirm modal
unable to click Delete yet
require user to type node name to delete
Type
snomiao-test/node-registry-testin the confirmation input boxable to click Delete now
Click delete
when succ: shows node deleted, and go back /nodes
when fail: shows failed msg
Tested in staging branch by @snomiao - ComfyUI Registry