Skip to content

Add Homebrew install instruction #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kidonng
Copy link

@kidonng kidonng commented Jun 6, 2025

I submitted ComfyUI Desktop to Homebrew and it's been available there for some time, it would be awesome if this is also mentioned in the official docs, instead of having to be discovered by users themselves.

Copy link
Member

@robinjhuang robinjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that! I tested and confirmed that this works. Could you do me a favor and change the download url on homebrew to this?

https://download.comfy.org/mac/dmg/arm64

@kidonng
Copy link
Author

kidonng commented Jun 10, 2025

Homebrew will auto update the version/URL shortly after a new release is made, so there's no need to always point to the latest version, which Homebrew prefer not to use if a stable version/URL is available.

@robinjhuang
Copy link
Member

@kidonng it's not the latest version I want to update. It's the host domain name

@kidonng
Copy link
Author

kidonng commented Jun 10, 2025

The resolved URL does point to ToDesktop though?

$ curl -i https://download.comfy.org/mac/dmg/arm64
HTTP/2 302
date: Tue, 10 Jun 2025 05:45:53 GMT
location: https://dl.todesktop.com/241012ess7yxs0e/mac/dmg/arm64

If ComfyUI does provide a versioned URL e.g. https://download.comfy.org/mac/dmg/arm64?version=0.4.51 then that can be used.

If you would really prefer Homebrew to use download.comfy.org as it currently is, I could submit a pull request for that, though it also requires version :latest and disabling checksumming, which I don't think is welcomed by Homebrew and users probably don't want that either.

Is there a technical reason for this?

@kidonng
Copy link
Author

kidonng commented Jun 10, 2025

Anyway, a little off-topic for this pull request, hit me (kidonng) on Comfy Discord if you feel GitHub is not the best place for discussion.

@robinjhuang
Copy link
Member

The technical reason is that we want to use our own domain as source of truth in case we move off todesktop in the future!

i believe https://download.comfy.org/mac/dmg/arm64?version=0.4.51 does work. Any query parameters that worked on the ToDesktop one should work here. This is just a proxy.

@kidonng
Copy link
Author

kidonng commented Jun 12, 2025

Consulting the docs, it seems to work for Windows binaries:

$ curl -i -L https://download.comfy.org/versions/0.4.32/windows
HTTP/2 302
date: Thu, 12 Jun 2025 09:02:07 GMT
location: https://dl.todesktop.com/241012ess7yxs0e/versions/0.4.32/windows
strict-transport-security: max-age=15724800; includeSubDomains

HTTP/2 200
date: Thu, 12 Jun 2025 09:02:08 GMT
content-type: binary/octet-stream
content-length: 138837280
accept-ranges: bytes
cache-control: no-store
content-disposition: attachment; filename="ComfyUI Setup 0.4.32 - x64.exe"

But not for Mac binaries:

$ curl -i -L https://download.comfy.org/versions/0.4.32/mac
HTTP/2 302
date: Thu, 12 Jun 2025 09:02:23 GMT
location: https://dl.todesktop.com/241012ess7yxs0e/versions/0.4.32/mac
strict-transport-security: max-age=15724800; includeSubDomains

HTTP/2 404
date: Thu, 12 Jun 2025 09:02:24 GMT
content-type: text/plain;charset=UTF-8
content-length: 21
server: cloudflare
cf-ray: 94e82b477e99dee3-NRT

Couldn't find mac app
$ curl -i -L https://download.comfy.org/versions/0.4.32/mac/dmg/arm64
HTTP/2 404
date: Thu, 12 Jun 2025 09:04:09 GMT
strict-transport-security: max-age=15724800; includeSubDomains

Assuming download.comfy.org points to dl.todesktop.com/241012ess7yxs0e, the resolved URL does work though:

$ curl -i -L https://dl.todesktop.com/241012ess7yxs0e/versions/0.4.32/mac/dmg/arm64
HTTP/2 200
date: Thu, 12 Jun 2025 09:05:29 GMT
content-type: binary/octet-stream
content-length: 176578936
accept-ranges: bytes
cache-control: no-store
content-disposition: attachment; filename="ComfyUI 0.4.32 - arm64.dmg"

Which means it could be something with the proxy, if you could figure that out.

But honestly, I don't see why we can't change Homebrew's source when you do move off ToDesktop. The change is not going to take days to reflect and prevent users from installing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants