New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N°5039 - DataSynchro: TEXT field too small for big linkset #479
base: support/2.7
Are you sure you want to change the base?
N°5039 - DataSynchro: TEXT field too small for big linkset #479
Conversation
Hello Thomas, I see the method you modified will be called for datasource table creation in \SynchroDataSource::AfterInsert |
Hmm, I only tested in iTop 3.0, but there the method was a bit different. The consistency check will indeed complain, but wouldn't the setup try to update the column instead? Edit: Seems to be the case for 3.0: iTop/synchro/synchrodatasource.class.inc.php Lines 1106 to 1117 in 4c626d0
iTop/synchro/synchrodatasource.class.inc.php Lines 1154 to 1155 in 4c626d0
And also for 2.7: iTop/synchro/synchrodatasource.class.inc.php Lines 1146 to 1161 in 4e95ca3
iTop/synchro/synchrodatasource.class.inc.php Lines 1206 to 1209 in 4e95ca3
|
@piRGoif ? |
@piRGoif any feedback? Also, what is the pending contributor update you are awaiting from me? |
Hello, |
Hello @piRGoif do you have any update for me please? |
@piRGoif ? |
Hello, |
Functional review:
|
@Molkobain when will the technical review happen? I see the PR is still on "pending functional review" on the dashboard.. |
This change is in order to be able to synchronise large linksets.