-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overrides to support Infallible #35
Open
daleswift
wants to merge
2
commits into
CombineCommunity:main
Choose a base branch
from
daleswift:feature/infallible
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// | ||
// Infallible+Combine.swift | ||
// RxCombine | ||
|
||
#if canImport(Combine) | ||
import Combine | ||
import RxSwift | ||
|
||
@available(OSX 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *) | ||
public extension Infallible { | ||
/// An `AnyPublisher` of the underlying Observable's Element type | ||
/// so the Infallible pushes events to the Publisher. | ||
var publisher: AnyPublisher<Element, Swift.Never> { | ||
RxInfalliblePublisher(upstream: self).eraseToAnyPublisher() | ||
} | ||
|
||
/// Returns a `AnyPublisher` of the underlying Observable's Element type | ||
/// so the Infallible pushes events to the Publisher. | ||
/// | ||
/// - returns: AnyPublisher of the underlying Observable's Element type. | ||
/// - note: This is an alias for the `publisher` property. | ||
func asPublisher() -> AnyPublisher<Element, Swift.Never> { | ||
publisher | ||
} | ||
} | ||
|
||
/// A Publisher of failure type Never pushing RxSwift events to a Downstream Combine subscriber. | ||
@available(OSX 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *) | ||
public class RxInfalliblePublisher<Upstream: ObservableConvertibleType>: Publisher { | ||
public typealias Output = Upstream.Element | ||
public typealias Failure = Swift.Never | ||
|
||
private let upstream: Upstream | ||
|
||
init(upstream: Upstream) { | ||
self.upstream = upstream | ||
} | ||
|
||
public func receive<S: Subscriber>(subscriber: S) where Failure == S.Failure, Output == S.Input { | ||
subscriber.receive(subscription: RxInfallibleSubscription(upstream: upstream, | ||
downstream: subscriber)) | ||
} | ||
} | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great. Another option could probably just do
asPublisher().assertNoFailure("Infallible should not fail")
and that way you don't need another custom Publisher type. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Could do that too. But RxInfallibleSubscriber already exists so why not use that? Seems a cleaner solution.
Either way. If you prefer assertNoFailure I’ll update to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean RxInfalliblePublisher ? it didn't exist, you just created it. I'm not keen on adding a new publisher like this because it inherently doesn't "do" anything and we erase the type anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I was referring to RxInfallibleSubscription which does already exist but is not used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I've changed it to use assertNoFailure as you suggested