#3316 Bugfix - Add new role functionality is throwing error #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage report for commit: e15e761 Summary - Lines: 3.00% | Methods: 5.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3395 +/- ##
========================================
Coverage 3.38% 3.38%
Complexity 584 584
========================================
Files 103 103
Lines 2065 2065
========================================
Hits 70 70
Misses 1995 1995 ☔ View full report in Codecov by Sentry. |
Passing run #7889 ↗︎
Details:
Review all test suite changes for PR #3395 ↗︎ |
|||||||||||||||
Abhinegi2
changed the title
Abhinegi2
added
the
status : ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets ##3316
Description of the changes
This pull request resolves the issue reported in #3316. The problem was traced back to incorrect naming conventions in the namespace of the
**roleRequest.php**file. The Laravel convention was not followed, causing an error in the add new role functionality. To address this, the file has been renamed to**RoleRequest.php**as per Laravel namespace standards.Checklist: