Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: slightly make the font size combo larger #9029

Merged
merged 1 commit into from
May 20, 2024
Merged

UI: slightly make the font size combo larger #9029

merged 1 commit into from
May 20, 2024

Conversation

meven
Copy link
Contributor

@meven meven commented May 10, 2024 •
edited

So even '88 pt' fit in without getting cut.

Change-Id: I950b99b2bed7b1e038e1847586b517807f3aa9b0

Summary

After:

image

Before:

image

Follow-up of #8979

pedropintosilva
pedropintosilva reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@pedropintosilva pedropintosilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks , nevertheless I see an interesting behaviour that makes me think that maybe there is a better way to handle this.

Currently font-size is actually affecting width even with this change. Example with 6.1 em width the component still gets cropped if I reduce the font-size to 10px. Wouldn't it be better to calculate the width based on the parent's font-size instead? Meaning, to use 5rem?

@meven meven force-pushed the meven/adjust-fontsize-combo branch from 7494eab to 118eb53 Compare May 16, 2024 12:58
@meven
Copy link
Contributor Author

meven commented May 16, 2024 •
edited

Thanks , nevertheless I see an interesting behaviour that makes me think that maybe there is a better way to handle this.

Currently font-size is actually affecting width even with this change. Example with 6.1 em width the component still gets cropped if I reduce the font-size to 10px. Wouldn't it be better to calculate the width based on the parent's font-size instead? Meaning, to use 5rem?

Thank you for refreshing my CSS skills.

I have tried different font size and 4.6 rem is enough for '88.5 pt' and scales with browser font-size nicely enough.

image

pedropintosilva
pedropintosilva approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@pedropintosilva pedropintosilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@meven @pedropintosilva
UI: slightly make the font size combo larger
d259bfa 
So even '88.5 pt' fits in without getting cut.

Signed-off-by: Méven Car <[email protected]>
Change-Id: I950b99b2bed7b1e038e1847586b517807f3aa9b0
@pedropintosilva
Copy link
Contributor

Encountered

Your configFile is invalid: /home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04_cypress_desktop/cypress_test/cypress.config.ts

It has been fixed and merged so, I have rebase this branch and force push it

@meven meven enabled auto-merge (rebase) May 17, 2024 13:25
@pedropintosilva
Copy link
Contributor

REtried since these are unrelated:

41 matches for "failed" in buffer: scratch
27:Failed
115:frk-468063-468063 2024-05-17 11:11:03.186983 +0000 [ forkit ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/test/../jails/468005-209ef4b6/BuhOQIl85f6rPUyj]| common/JailUtil.cpp:106
321:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: mount failed remount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd] readonly: Permission denied.
323:kit-472862-472862 2024-05-17 11:11:12.153976 +0000 [ kit_spare_008 ] ERR Failed to mount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/test/../systemplate] -> [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd/] readonly| common/JailUtil.cpp:79
324:kit-472862-472862 2024-05-17 11:11:12.154000 +0000 [ kit_spare_008 ] ERR Failed to mount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/test/../systemplate] -> [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd/], will link/copy contents.| kit/Kit.cpp:3026
333:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd/lo] failed: Permission denied.
334:kit-472862-472862 2024-05-17 11:11:12.195502 +0000 [ kit_spare_008 ] ERR Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd/lo]| common/JailUtil.cpp:104
553:wsd-468005-468005 2024-05-17 11:11:23.091599 +0000 [ coolwsd ] TST UnitSaveOnExitSaved [exitTest] (+125348ms): ERROR: FAILURE: exitTest: TestResult::Failed| common/Unit.cpp:530
611:wsd-468005-468005 2024-05-17 11:11:23.092180 +0000 [ coolwsd ] TST UnitSaveOnExitSaved [onExitTest] (+125349ms): Setting TerminationFlag as the Test Suite failed| common/Unit.cpp:701
652:kit-472862-472862 2024-05-17 11:11:23.092278 +0000 [ kit_spare_008 ] ERR #25: Read failed, have 0 buffered bytes (ECONNRESET: Connection reset by peer)| net/Socket.hpp:1146
1108:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a/MfNoQYioaAHXmDxd/lo] failed: Permission denied.
1109:wsd-468005-468005 2024-05-17 11:11:23.507758 +0000 [ coolwsd ] ERR Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a/MfNoQYioaAHXmDxd/lo]| common/JailUtil.cpp:104
1112:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a/MfNoQYioaAHXmDxd] failed: Permission denied.
1113:wsd-468005-468005 2024-05-17 11:11:23.514618 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a/MfNoQYioaAHXmDxd]| common/JailUtil.cpp:106
1118:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a] failed: Permission denied.
1120:wsd-468005-468005 2024-05-17 11:11:23.521796 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a]| common/JailUtil.cpp:106
1130:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb/kUtM8JobdiU024b0/lo] failed: Permission denied.
1131:wsd-468005-468005 2024-05-17 11:11:23.534475 +0000 [ coolwsd ] ERR Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb/kUtM8JobdiU024b0/lo]| common/JailUtil.cpp:104
1134:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb/kUtM8JobdiU024b0] failed: Permission denied.
1135:wsd-468005-468005 2024-05-17 11:11:23.540324 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb/kUtM8JobdiU024b0]| common/JailUtil.cpp:106
1140:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb] failed: Permission denied.
1142:wsd-468005-468005 2024-05-17 11:11:23.545243 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb]| common/JailUtil.cpp:106
1152:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd/lo] failed: Permission denied.
1153:wsd-468005-468005 2024-05-17 11:11:23.555588 +0000 [ coolwsd ] ERR Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd/lo]| common/JailUtil.cpp:104
1156:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd] failed: Permission denied.
1157:wsd-468005-468005 2024-05-17 11:11:23.561418 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/JvMEUwsxDNk61XDd]| common/JailUtil.cpp:106
1166:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/hjioufWDuH23qiwY/lo] failed: Permission denied.
1167:wsd-468005-468005 2024-05-17 11:11:23.613954 +0000 [ coolwsd ] ERR Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/hjioufWDuH23qiwY/lo]| common/JailUtil.cpp:104
1170:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/hjioufWDuH23qiwY] failed: Permission denied.
1171:wsd-468005-468005 2024-05-17 11:11:23.620926 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6/hjioufWDuH23qiwY]| common/JailUtil.cpp:106
1177:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6] failed: Permission denied.
1178:wsd-468005-468005 2024-05-17 11:11:23.669124 +0000 [ coolwsd ] DBG Failed to unmount [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/468005-209ef4b6]| common/JailUtil.cpp:106
1183:wsd-468005-468005 2024-05-17 11:11:23.669247 +0000 [ coolwsd ] TST UnitBase [uninit] (+125926ms): Uninitializing unit-tests: FAILED| common/Unit.cpp:355
1185:wsd-468005-468005 2024-05-17 11:11:23.669277 +0000 [ coolwsd ] TST UnitSaveOnExitSaved [~UnitBase] (+125926ms): UnitSaveOnExitSaved: ~UnitBase: FAILED| common/Unit.cpp:429
1194:Test failed on unit-wopi-save-on-exit after 126s. Re-run with (remove --unattended to run without gdb and get prompted):
1219:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a/MfNoQYioaAHXmDxd/lo] failed: Permission denied.
1220:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a/MfNoQYioaAHXmDxd] failed: Permission denied.
1221:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/472048-2303b49a] failed: Permission denied.
1222:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb/kUtM8JobdiU024b0/lo] failed: Permission denied.
1223:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb/kUtM8JobdiU024b0] failed: Permission denied.
1224:/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/coolmount: forced unmount of [/home/collabora/jenkins/workspace/github_online_master_debug_vs_co-24.04/jails/466438-e88b1dcb] failed: Permission denied.

@meven meven merged commit f6e824d into CollaboraOnline:master May 20, 2024
14 checks passed
@meven meven deleted the meven/adjust-fontsize-combo branch May 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedropintosilva pedropintosilva pedropintosilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Collabora Online
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meven @pedropintosilva