Presentations: Ruler #8966
Open
Presentations: Ruler #8966
+87
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this #7405 |
Yes this the enhancment |
|
WIP changes in CORE: https://gerrit.libreoffice.org/c/core/+/167060 |
Darshan-upadhyay1110
force-pushed
the
private/darshan/add-ruler-to-odp
branch
from
e9f26b4
to
37b277a
Compare
Darshan-upadhyay1110
force-pushed
the
private/darshan/add-ruler-to-odp
branch
from
37b277a
to
5a17001
Compare
Darshan-upadhyay1110
force-pushed
the
private/darshan/add-ruler-to-odp
branch
from
5a17001
to
e5b3ce1
Compare
|
Final CORE changes: https://gerrit.libreoffice.org/c/core/+/168276/1 To test this online patch, please build CORE with above PR |
- Initialized ruler UI for DOCTYPE Presentation - Now functionality is available independent of the selected view. - Ruler is present in both Compact/Tabbed view Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: Ie443a69d0afead8fde2ac08b63442b491710fcb8
- data in ruler for impress are quite diffrent compare to what we expect in writer - handled calculation which will work for all apps - for impress we need to consider the left presentation wrraper part as well and take that into account for left/right margin calculation Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I793ff0bba82dd47da0322e12cfd975378fe41d4b
Darshan-upadhyay1110
force-pushed
the
private/darshan/add-ruler-to-odp
branch
from
e5b3ce1
to
06bc34e
Compare
- if ruler is enabled get response on initilaization - this patch will also handle some tricky condition like if ruler not enabled we will not request for ruler data. - as a next step we will get ruler data if user enabled it using UI menu option Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: Icd98a7fef01c0360779c33c906161edcee498944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan-upadhyay1110 [email protected]
Change-Id: Ie443a69d0afead8fde2ac08b63442b491710fcb8
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay