draw: constrain object move with Shift #7958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
from
bea298c to
0e64b3a
Compare
|
Currently sitting on top of #7860 - it's needed. |
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
from
0e64b3a to
e869091
Compare
Minion3665
force-pushed
the
private/hub/constrain-drag
branch
from
e869091 to
10c1365
Compare
|
(rebased as #7860 was merged) |
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
from
10c1365 to
731a51a
Compare
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
2 times, most recently
from
849c195 to
e7134e3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
from
e7134e3 to
a42e8af
Compare
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
from
a42e8af to
724ff3e
Compare
- Added src/layer/vector/Path.Constraint.ts Issue #7933 Signed-off-by: Hubert Figuière <[email protected]> Change-Id: Ie39c15a8552276bc5919ffbbd5dd859695048b9c
hfiguiere
force-pushed
the
private/hub/constrain-drag
branch
from
724ff3e to
347b1ef
Compare
5 tasks
|
@gokaysatir is this PR something stil valid with new grid? |
Yes this seems still good to have. Just checked the feature, not the code. |
|
It was imperfect back then and some recent rework broke it completely. The part that did constrain when dragging is gone as SVGGroup got refactored. I didn't try to fix it since. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7933
Change-Id: Ie39c15a8552276bc5919ffbbd5dd859695048b9c
Summary
Press shift when dragging (screencast out of date)
Screencast.from.2024-01-05.17-49-59.webm
TODO
Checklist
make checkmake runand manually verified that everything looks okay