-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add languagetool support #6929
base: master
Are you sure you want to change the base?
Conversation
2197109
to
ca73654
Compare
@Rash419 do you have an tipp - where the Containerfile/Dockerfile for your languagetool container are? i like to review and take an look inside the setup / start.sh it correct. In past i use this files: i believe i have to use for the ngram part an init container (and reimplement that script there). |
ca73654
to
48f1b7b
Compare
@genofire tbh I have no idea about languagetool , maybe @timar can help us here |
74b81a8
to
4c1460b
Compare
I found #!/bin/bash
EXTRAOPTIONS=""
[ -d "/ngrams" ] && EXTRAOPTIONS=" --languageModel /ngrams "
java -cp languagetool-server.jar org.languagetool.server.HTTPServer --port 8010 --public --allow-origin '*' ${EXTRAOPTIONS} Could we update it to: #!/usr/bin/env bash
EXTRAOPTIONS=${EXTRAOPTIONS:-}
JAVAOPTIONS=${JAVAOPTIONS:-}
if [ -d "/ngrams" ]; then
EXTRAOPTIONS="${EXTRAOPTIONS} --languageModel /ngrams"
fi
for var in ${!LT_*}; do
EXTRA_LT=true
echo "${var#'LT_'}="${!var} >> /tmp/config.properties
done
echo JAVAOPTIONS=$JAVAOPTIONS
if [ "$EXTRA_LT" = true ]; then
EXTRAOPTIONS="${EXTRAOPTIONS} --config /tmp/config.properties"
echo config.properties:
echo "$(cat /tmp/config.properties)"
fi
echo EXTRAOPTIONS=$EXTRAOPTIONS
java ${JAVAOPTIONS} -cp languagetool-server.jar org.languagetool.server.HTTPServer --port 8010 --public --allow-origin '*' ${EXTRAOPTIONS} For:
Otherwise I need to reimplement it inside this helmchart again |
Signed-off-by: genofire <[email protected]> Change-Id: I5634255410fe43523186003ab95fa14dadaf43d1
4c1460b
to
e19a764
Compare
Rash - can we get this merged & closed or actioned in some useful way ? =) |
We wait feedback from @timar for your image of languagetools, so i could also create monitoring and ngram loading in this helm-chart. That does not depends on @Rash419 |
- make EXTRAOPTION modifyable - add JAVAOPTIONS - add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics Contributed by @genofire at CollaboraOnline/online#6929 (comment) Signed-off-by: Andras Timar <[email protected]>
- make EXTRAOPTION modifyable - add JAVAOPTIONS - add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics Contributed by @genofire at CollaboraOnline/online#6929 (comment) Signed-off-by: Andras Timar <[email protected]>
@genofire I pushed languagetools image with the startup scirpt you suggested. |
Hi @genofire! Great news—timar has added the language tool, so you can go ahead. Assigning task back to you 😉 |
- make EXTRAOPTION modifyable - add JAVAOPTIONS - add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics Contributed by @genofire at CollaboraOnline/online#6929 (comment) Signed-off-by: Andras Timar <[email protected]>
okay, i will take a look in this again ;) |
- make EXTRAOPTION modifyable - add JAVAOPTIONS - add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics Contributed by @genofire at CollaboraOnline/online#6929 (comment) Signed-off-by: Andras Timar <[email protected]>
@Rash419 what should we do with this PR? |
@genofire are you still working on this ? Do you need help to finish this PR ? |
Summary
@Rash419 for you later - still in developing
TODO