Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add languagetool support #6929

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

genofire
Copy link
Contributor

@genofire genofire commented Jul 18, 2023

Summary

@Rash419 for you later - still in developing

TODO

  • add initContainer to download ngram correctly
  • Testing if it works

@genofire genofire force-pushed the feat/helm-languagetools branch 2 times, most recently from 2197109 to ca73654 Compare July 18, 2023 13:45
@genofire
Copy link
Contributor Author

genofire commented Jul 18, 2023

@Rash419 do you have an tipp - where the Containerfile/Dockerfile for your languagetool container are?

i like to review and take an look inside the setup / start.sh it correct.

In past i use this files:
https://github.com/someone-stole-my-name/docker-languagetool/blob/master/misc/init.sh
https://github.com/someone-stole-my-name/docker-languagetool/blob/master/misc/ngram.sh

i believe i have to use for the ngram part an init container (and reimplement that script there).

@genofire genofire force-pushed the feat/helm-languagetools branch from ca73654 to 48f1b7b Compare July 18, 2023 14:02
@Rash419
Copy link
Contributor

Rash419 commented Jul 18, 2023

@Rash419 do you have an tipp - where the Containerfile/Dockerfile for your languagetool container are?

i like to review and take an look inside the setup / start.sh it correct.

In past i use this files: https://github.com/someone-stole-my-name/docker-languagetool/blob/master/misc/init.sh https://github.com/someone-stole-my-name/docker-languagetool/blob/master/misc/ngram.sh

i believe i have to use for the ngram part an init container (and reimplement that script there).

@genofire tbh I have no idea about languagetool , maybe @timar can help us here

@genofire genofire force-pushed the feat/helm-languagetools branch 3 times, most recently from 74b81a8 to 4c1460b Compare July 20, 2023 06:42
@genofire
Copy link
Contributor Author

genofire commented Jul 20, 2023

@timar

I found /start.sh with:

#!/bin/bash

EXTRAOPTIONS=""
[ -d "/ngrams" ] && EXTRAOPTIONS=" --languageModel /ngrams "

java -cp languagetool-server.jar  org.languagetool.server.HTTPServer --port 8010 --public --allow-origin '*' ${EXTRAOPTIONS}

Could we update it to:

#!/usr/bin/env bash

EXTRAOPTIONS=${EXTRAOPTIONS:-}
JAVAOPTIONS=${JAVAOPTIONS:-}

if [ -d "/ngrams" ]; then
    EXTRAOPTIONS="${EXTRAOPTIONS} --languageModel /ngrams"
fi

for var in ${!LT_*}; do
  EXTRA_LT=true
  echo "${var#'LT_'}="${!var} >> /tmp/config.properties
done

echo JAVAOPTIONS=$JAVAOPTIONS
if [ "$EXTRA_LT" = true ]; then
  EXTRAOPTIONS="${EXTRAOPTIONS} --config /tmp/config.properties"
    echo config.properties:
    echo "$(cat /tmp/config.properties)"
fi
echo EXTRAOPTIONS=$EXTRAOPTIONS

java ${JAVAOPTIONS} -cp languagetool-server.jar org.languagetool.server.HTTPServer --port 8010 --public --allow-origin '*' ${EXTRAOPTIONS}

For:

Otherwise I need to reimplement it inside this helmchart again

Signed-off-by: genofire <[email protected]>
Change-Id: I5634255410fe43523186003ab95fa14dadaf43d1
@genofire genofire force-pushed the feat/helm-languagetools branch from 4c1460b to e19a764 Compare August 25, 2023 16:09
@mmeeks mmeeks requested a review from Rash419 April 18, 2024 09:04
@mmeeks
Copy link
Contributor

mmeeks commented Apr 18, 2024

Rash - can we get this merged & closed or actioned in some useful way ? =)

@genofire
Copy link
Contributor Author

genofire commented Apr 18, 2024

We wait feedback from @timar for your image of languagetools, so i could also create monitoring and ngram loading in this helm-chart.

That does not depends on @Rash419

@timar timar self-assigned this Sep 5, 2024
timar added a commit to CollaboraOnline/docker-languagetool that referenced this pull request Sep 5, 2024
- make EXTRAOPTION modifyable
- add JAVAOPTIONS
- add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics

Contributed by @genofire at CollaboraOnline/online#6929 (comment)

Signed-off-by: Andras Timar <[email protected]>
timar added a commit to CollaboraOnline/docker-languagetool that referenced this pull request Sep 5, 2024
- make EXTRAOPTION modifyable
- add JAVAOPTIONS
- add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics

Contributed by @genofire at CollaboraOnline/online#6929 (comment)

Signed-off-by: Andras Timar <[email protected]>
@timar
Copy link
Member

timar commented Sep 5, 2024

We wait feedback from @timar for your image of languagetools, so i could also create monitoring and ngram loading in this helm-chart.

That does not depends on @Rash419

@genofire I pushed languagetools image with the startup scirpt you suggested.

@timar timar removed their assignment Sep 5, 2024
@Darshan-upadhyay1110
Copy link
Contributor

Hi @genofire! Great news—timar has added the language tool, so you can go ahead. Assigning task back to you 😉

timar added a commit to CollaboraOnline/docker-languagetool that referenced this pull request Sep 9, 2024
- make EXTRAOPTION modifyable
- add JAVAOPTIONS
- add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics

Contributed by @genofire at CollaboraOnline/online#6929 (comment)

Signed-off-by: Andras Timar <[email protected]>
@genofire
Copy link
Contributor Author

okay, i will take a look in this again ;)

silvio pushed a commit to silvio/docker-languagetool that referenced this pull request Sep 27, 2024
- make EXTRAOPTION modifyable
- add JAVAOPTIONS
- add LT_ for https://languagetool.org/development/api/org/languagetool/server/HTTPServerConfig.html for e.g. enable PrometheusMetrics

Contributed by @genofire at CollaboraOnline/online#6929 (comment)

Signed-off-by: Andras Timar <[email protected]>
@eszkadev
Copy link
Contributor

@Rash419 what should we do with this PR?

@eszkadev eszkadev added the draft label Oct 24, 2024
@Rash419
Copy link
Contributor

Rash419 commented Oct 28, 2024

@genofire are you still working on this ? Do you need help to finish this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

6 participants