wsd: simplify serializing sliderenderingcomplete: #13552
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the EnableExperimental log when serializing the 'sliderenderingcomplete:' command, converts the JSON literals to raw string and uses std::ostringstream to avoid temporary strings. Change-Id: I5db8fd9a8b940954e685fd2b65ef63bb5c1ac3b8 Signed-off-by: Ashod Nakashian <[email protected]>
codewithvk
approved these changes
Nov 23, 2025
Contributor
codewithvk
left a comment
codewithvk
left a comment
There was a problem hiding this comment.
Looks sensible to me, thanks @Ashod!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the EnableExperimental log when
serializing the 'sliderenderingcomplete:'
command, converts the JSON literals to
raw string and uses std::ostringstream
to avoid temporary strings.
Change-Id: I5db8fd9a8b940954e685fd2b65ef63bb5c1ac3b8
Signed-off-by: Ashod Nakashian [email protected]