Include and Header Cleanup #13551
Open
Include and Header Cleanup #13551
+152
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6a262965fc3cdbb9cf36985bcbde8a000b03693d Signed-off-by: Ashod Nakashian <[email protected]>
It's best to have config.h only in .cpp files, and always as the first include, rather than in .hpp. This is because having .hpp include config.h makes it impossible to guarantee that config.h is the first to be included. This causes major, but possibly silent and hidden, breaks due to the config.h directives not being effective on headers included before it. This will happen for example when the .hpp that has the config.h is not the first to be included in the .cpp. All the .hpp files included before it will not have the config.h and therefore checking/using the directives will yield a different result, breaking consistency. Change-Id: Iacfdd348643e3bf25834968dd9cda9d95a2efdac Signed-off-by: Ashod Nakashian <[email protected]>
More readable. Change-Id: I8e2c5f9eb5f9af97a5b161e8ad2d508bdf55c888 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I157ac26367e14ebd9939d4b1dec1a35ee104251d Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I90498b9faefb81df2c554bc0a1b35628a372402c Signed-off-by: Ashod Nakashian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's best to have config.h only
in .cpp files, and always as the
first include, rather than in .hpp.
This is because having .hpp include
config.h makes it impossible to guarantee
that config.h is the first to be included.
This causes major, but possibly silent
and hidden, breaks due to the config.h
directives not being effective on
headers included before it. This will
happen for example when the .hpp that
has the config.h is not the first to
be included in the .cpp. All the .hpp
files included before it will not have
the config.h and therefore checking/using
the directives will yield a different
result, breaking consistency.