Private/gokay/redline #13545
Merged
Private/gokay/redline #13545
+1
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: It was referencing a deleted structure. Use "rectanglesOriginal" variable for showing redlines as commnets. Normal comments is already using it. The purpose is the same for both. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ifad4fa9bf49b2519e41594dfea4fb501d7fce34a
Non of the functions inside the file is used anymore. * clipPolygon * rectanglesToPolygons Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I6ab17f1de1910d417db351dcd357deaf73a9288f
eszkadev
approved these changes
Nov 23, 2025
Contributor
eszkadev
left a comment
eszkadev
left a comment
There was a problem hiding this comment.
I like the fix which mostly removes the old code :)
it works now, thanks for quick fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay