accessibility: refactor frame handling to improve group eligibility logic #13541
+6
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic Before: fieldset/legend were only applied to explicit form-control groups After: fieldset/legend are applied wherever a semantic group label is needed for accessibility Signed-off-by: Parth Raiyani <[email protected]> Change-Id: Id8cc965403935b21590910903cf894080212c563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: fieldset/legend were only applied to explicit form-control groups
After: fieldset/legend are applied wherever a semantic group label is needed for accessibility
Change-Id: Id8cc965403935b21590910903cf894080212c563
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay