fix a11y-aria-attribute #13537
Open
fix a11y-aria-attribute #13537
+188
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndling in label updates This change will prioritize label's 'for' attribute for labelable elements or add 'aria-labelledby' attribute otherwise Signed-off-by: Parth Raiyani <[email protected]> Change-Id: If7f08685daa2c26643baee819abfb8c74dd5d98a
… aria label handling Change-Id: Ib8a0336da6ae06df911dd32ef32b45fcca2e9519 Signed-off-by: Parth Raiyani <[email protected]>
…ts in JSDialog This method will first prioritize 'aria-labelledby' and then 'aria-label'. we can simply call this method from anywhere to add aria attributes correctly Change-Id: I2de47882e3d34f90f15ed2518d609c997e33b38a Signed-off-by: Parth Raiyani <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rparth07
force-pushed
the
private/rparth07/a11y-aria-attr-fix
branch
from
c14c47b to
e3d10fb
Compare
This was referenced Nov 21, 2025
…belable elements in JSDialog components This method applies labels in the following priority: 1. <label> with 'for' attribute pointing to the element but used only if the label correctly references this element 2. aria-labelledby referencing an existing element and apply only if no label element exist or label's for attribute doesn't match 3. aria-label used as fallback when <label> or labelledBy does not exist All relevant changes are made to ensure above priority. This common method will be useful for adding ARIA attributes in future Change-Id: Ia4e5bcbf2e613cdc964b398392ca7fd82a670a0b Signed-off-by: Parth Raiyani <[email protected]>
…ssibility using SetupA11yLabelForLabelableElement Signed-off-by: Parth Raiyani <[email protected]> Change-Id: Id8bd3255dc1130b0ac54911135fce6240dc60cf6
…for improved screen reader support Signed-off-by: Parth Raiyani <[email protected]> Change-Id: I0207c7c914034160fa9a01f4135beac2be637cbf
rparth07
force-pushed
the
private/rparth07/a11y-aria-attr-fix
branch
from
e3d10fb to
f7520ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
_fixedtextControlmethod to also prioritizeforattribute before referencing witharia-labelledbyfor labelable elementsAs this can act as a common solution for ARIA attribute related issue. we no longer need change in #13526 and #13527 but relevant core patches still needed.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay