impress: Remove reply action from comment context menu #13534
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Replies currently merge into the parent comment body instead of creating a child comment card. -Until proper threaded replies are implemented, the reply option is removed to prevent incorrect behavior Signed-off-by: Banobe Pascal <[email protected]> Change-Id: I93e0916dec48e5f6c89f6708b18877ca1ab04983
banobepascal
force-pushed
the
private/banobepascal/impress-reply
branch
from
f5f81b6 to
f7cb98e
Compare
eszkadev
reviewed
Nov 21, 2025
| cy.cGet('.annotation-marker').should('not.exist'); | ||
| }); | ||
|
|
||
| it('Reply',function() { |
Contributor
There was a problem hiding this comment.
can we add comment above why this section is skipped?
also can we add test that checks just if reply is NOT visible? so it will be obvious it is expected :)
-Since reply functionality is temporary removed, the associated tests are skipped until threaded replies are implemented. -Added a new test to explicitly assert that the "Reply" option is not visible in the context menu Signed-off-by: Banobe Pascal <[email protected]> Change-Id: Id95492a17ad0633296aedce903bd916bc052ffc9
banobepascal
force-pushed
the
private/banobepascal/impress-reply
branch
from
f7cb98e to
9e8a68f
Compare
banobepascal
commented
Nov 21, 2025
eszkadev
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I2fb42256101daec6462f0472aac8941eb93953ce
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay