Skip to content

Conversation

@mohit-marathe
Copy link
Contributor

@mohit-marathe mohit-marathe commented Nov 12, 2025

Change-Id: I82120479cf599f9058a6151cda0827ea12c8d777

  • Target version: master

This feature is currently experimental as there are some bugs that I want to fix.

screenshot_21112025_170848

@mohit-marathe mohit-marathe force-pushed the private/mohitm/insert-canvas-slide branch 2 times, most recently from d2d3908 to 1cc824b Compare November 12, 2025 15:07
@mohit-marathe mohit-marathe force-pushed the private/mohitm/insert-canvas-slide branch from 1cc824b to a1f62db Compare November 14, 2025 04:44
@github-project-automation github-project-automation bot moved this from To Review to In Progress in Collabora Online Nov 17, 2025
@mohit-marathe mohit-marathe force-pushed the private/mohitm/insert-canvas-slide branch 3 times, most recently from 05775e3 to 2f0dd46 Compare November 18, 2025 11:04
@github-project-automation github-project-automation bot moved this from In Progress to To Test in Collabora Online Nov 18, 2025
Copy link
Contributor

@pedropintosilva pedropintosilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohit-marathe this is what I see:

Image Image

I'm a bit confused, I thought we would have always in the maximum one canvas slide per presentation. What maybe I understood it wrong? (What would be the user flow that requires more than one?)

That apart, I think we should use a split button instead in the insert button. The same as we use in the home tab (with icon view) and then just add a button at the bottom (similar as we have for that Margins button in Writer > Layout or in Calc. And then we would have the New Canvas Slide button on both Home and Insert tab:

Image

@github-project-automation github-project-automation bot moved this from To Test to In Progress in Collabora Online Nov 19, 2025
@mohit-marathe
Copy link
Contributor Author

@pedropintosilva

I'm a bit confused, I thought we would have always in the maximum one canvas slide per presentation.

That's right.
I think the label can be more clear. I just followed the convention for labeling this uno command from: https://github.com/LibreOffice/core/blob/distro/collabora/co-25.04/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu#L827..L845

@pedropintosilva
Copy link
Contributor

Mohit has confirmed there is only one canvas slide per document, always.

@mohit-marathe mohit-marathe force-pushed the private/mohitm/insert-canvas-slide branch from 2f0dd46 to fef49c4 Compare November 21, 2025 11:40
- Add buttons for .uno:InsertCanvasSlide and .uno:ReshufflePages
- Create Widget.NewSlideLayoutEntry.ts for having both grid, and a
  separate button in the dropdown

Signed-off-by: Mohit Marathe <[email protected]>
Change-Id: I82120479cf599f9058a6151cda0827ea12c8d777
@mohit-marathe mohit-marathe force-pushed the private/mohitm/insert-canvas-slide branch from fef49c4 to b1cedb6 Compare November 21, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants