Typescript conversion of the internals of L.Evented #11276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisfrancis
force-pushed
the
private/dennisf/typescript
branch
from
2ef849c to
5297db8
Compare
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ibbea012807716d481962e2354b04375cfe82127a
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I85ea2261a7557d5d5dbe59a642a1267fe7c4c4ee
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ica4ac6c9f38334263c45182e16cd52bdb7277f03
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I4b358324f708b04dea4d5c1c017537d12fc319ee
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ic64a07d4d62e7a0967b58aaff6865ad31ee813e6
when we fully get rid of L.Evented or in a fully typed world like mocha tests. Signed-off-by: Dennis Francis <[email protected]> Change-Id: I802766adf4d53312da11573ed1108c1df155802e
both foreign context events and self context event containers are empty. Signed-off-by: Dennis Francis <[email protected]> Change-Id: I138fe462f4bd130a52912801d5b890f3b1460f89
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ic89b5e118441df02f6447580cd8ba5d38d57f7a9
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Idab511f63d606024c85494bb73e79826778dfa5d
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I46155ac34dcc36f88b0ff5ac04a46607e2d0ad10
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I8b0b6e4bc67410eb0d88454cf7e0a6326c62c2dc
Signed-off-by: Dennis Francis <[email protected]> Change-Id: I184df2f8c1b6902f2b2f58d429212f90ded35e2b
... call-types and context-types. Signed-off-by: Dennis Francis <[email protected]> Change-Id: I5364af9c92cf58a41dcb36691be5d300ed862c93
Signed-off-by: Dennis Francis <[email protected]> Change-Id: Ie2c715290bf5ca1fb889fa0855ec5117dd42f312
dennisfrancis
force-pushed
the
private/dennisf/typescript
branch
from
0c3b162 to
1ba3558
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Dennis Francis <[email protected]> Change-Id: If85e88487eb2aeeff9eaf45da51a35528d1b69e8
mmeeks
reviewed
Mar 8, 2025
| @@ -0,0 +1,69 @@ | |||
| /// <reference path="../../src/app/BaseClass.ts"/> | |||
mmeeks
reviewed
Mar 8, 2025
| } | ||
|
|
||
| // attach listener | ||
| private _on(type: string, fn: CEventListener, context: any): void { |
There was a problem hiding this comment.
the comment is a good sign this function is misnamed =) can we have attachListener(...) instead ? =)
| } | ||
| } | ||
|
|
||
| private _off(type: string, fn: CEventListener, context: any): void { |
There was a problem hiding this comment.
and I guess removeListener ? =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typescript conversion of the internals of L.Evented
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay