Unload While Loading #11270
Open
Unload While Loading #11270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashod
force-pushed
the
private/ash/unload
branch
from
52f285e to
241d73b
Compare
mmeeks
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Looks very sensible - but we badly need to catch all of these corner cases which are easy to forget in future. Hopefully now we understand it it shouldn't be that hard to do.
I would like a C++ unit test for this - perhaps we need to add new hooks for that - can you prioritize that ? =)
Good work.
Ashod
force-pushed
the
private/ash/unload
branch
2 times, most recently
from
49de65c to
9ec6c4a
Compare
When the client disconnects while we are loading the document, we risk getting in an invalid state. When we get disconnected while loading, we have logic to terminate the kit. Unfortunately, we don't account for the fact that the session isn't yet removed from the container, and fail to detect this case. Furtheremore, we should stop the DocBroker poll, which we didn't previously. Change-Id: I19290f6252e445202132f6a6a9aa1987183919cf Signed-off-by: Ashod Nakashian <[email protected]>
In the event that we gave up on loading, we should never change the state back to LIVE once we are in WAIT_DISCONNECT. This was caught with: WRN ToClient-002: Unusual race - attempts to transition from SessionState::WAIT_DISCONNECT to SessionState::LIVE| wsd/ClientSession.cpp:151 Change-Id: I6ed5ca19586facb801d2169f7cf66ed443cef310 Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/unload
branch
from
9ec6c4a to
0c0cb8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wsd: handle disconnection while loading
When the client disconnects while we are
loading the document, we risk getting
in an invalid state.
When we get disconnected while loading,
we have logic to terminate the kit.
Unfortunately, we don't account for
the fact that the session isn't yet
removed from the container, and fail
to detect this case. Furtheremore,
we should stop the DocBroker poll,
which we didn't previously.
Also, we fix an invalid state transition:
wsd: avoid transitioning to LIVE from WAIT_DISCONNECT
wsd: avoid transitioning to LIVE from WAIT_DISCONNECT
In the event that we gave up on loading,
we should never change the state back to LIVE
once we are in WAIT_DISCONNECT.
This was caught with: WRN ToClient-002: Unusual race - attempts to
transition from SessionState::WAIT_DISCONNECT to SessionState::LIVE|
wsd/ClientSession.cpp:151