Private/caolan/pahole #11238
Open
Private/caolan/pahole #11238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolan/pahole
branch
2 times, most recently
from
986fa6b to
c84bb55
Compare
…ings and how to build your own if needs be Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I00c3a267e8ba3e9a2cebb0c00052682c73158506
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ie9b101041cdbf36def86099ae83343ea7435c484
Signed-off-by: Caolán McNamara <[email protected]> Change-Id: Ia1a7800db425c1220c4456e9588d44d4a7decebf
do this one individually as it was originally explicitedly commented to be 'Last member' Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I3ad11729ccb0efb7d59d266f0eec46ec966d73ae
needs pahole, and in practice seems to need clang++ with -fno-eliminate-unused-debug-types along with the usual -g otherwise at least std::fstream is seen as size 0 Signed-off-by: Caolán McNamara <[email protected]> Change-Id: I7687223e551ab9ae1f44be368e799edcc141e928
caolanm
force-pushed
the
private/caolan/pahole
branch
from
c84bb55 to
5fa9fd8
Compare
mmeeks
reviewed
Feb 27, 2025
|
What can be packed was autogenerated with included incantation, but the ordering was manual, albeit mechanical by largest first and e.g. fancy std::atomics grouped before bools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay