Private/gokay/multi page writer 2 #11237
Open
+536
−457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gokaysatir
force-pushed
the
private/gokay/multi-page-writer-2
branch
from
79faaf5 to
6a9ad69
Compare
gokaysatir
force-pushed
the
private/gokay/multi-page-writer-2
branch
5 times, most recently
from
0ac4e1b to
3f64662
Compare
gokaysatir
force-pushed
the
private/gokay/multi-page-writer-2
branch
2 times, most recently
from
8b763e8 to
8ed78ed
Compare
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ib9a27746f57b58e53cc3fd6d81498d79aea078d4
…sMultiPageView function. Remove commented-out code. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ie987a070199c63177be73dc04287c0471afa02f2
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I5b46a731cb0de89c54f80c077fcca326d0cae95b
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Iae57ccc92dedf9a6f324f8b6bc17969d00e6014e
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I4591214af61edaa1545a984f53c73970fef24856
app.view.size is used for scrolling and other view related parts. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I8bf691d6b83cd2eb84fb117ab34317085230af71
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ifc03afc615db02319a1f1f8dd3ab3116eb4fd476
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I13d41fbf208b5e8b172d5846836cb63b340ff9c9
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I8ae11962f18620f0bac69e70b2f17bfaf09dc2bb
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I7fbea7fdd03a992e1321de4ed89a7df9efd84299
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I531d232e5e024dba712f379567ec10ddb659e81c
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ide2b3251535a60eef50ef62811fc416f8fa0957e
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Iad41f13743c4cb796c41df2108ff73972742996b
…nvasSectionContainer. Use app.file.viewedRectangle instead. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I970be2e9c66d78b08be85696e2c67cc0d5bde888
…CanvasBottom to .getHeight. For better readability. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I9305b96616d8e06e96114ec5101d9ad959156f4d
…checks. Remove unused variables. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I1edcdd1e202c3134f209393e5580d348eb5b10c4
Set app.file.viewedRectangle via resetViewLayout. Use scrolled position when drawing page rectangles in multiple page view. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I12d8936efd874e0045fb0dab2bca4ac84657ce9b
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Iccb4122c868c5042e6d9109213e9b4271c72fc80
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I2a0748f2a489467aedf418c078074116d9133ece
Use getWidth, getHeight and getViewSize functions instead. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I54d34ac6dda7ffa6490d7bc6da4aa5655a4bc90b
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ifdd1d91cff1238269c5b7f2bf5a7188d244c9115
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ica8cf4bd678e49dc4d2b5ca3e4637195f2bc650c
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I0acdb233d1159356a4c89e7a64c99069b2f84a52
Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Ieaea97b4d527d3ea850e59af08d68eab633eab7b
Fix issue with rounding errors. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I88edaf2117998b14a3bfdcb6741dc9ba6411fd16
gokaysatir
force-pushed
the
private/gokay/multi-page-writer-2
branch
from
8ed78ed to
588bd00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay