browser: accessibility: add 'aria-disabled' attribute #11082
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcvcastro
force-pushed
the
pr/master/A0
branch
5 times, most recently
from
a127670 to
c06b601
Compare
hcvcastro
force-pushed
the
pr/master/A0
branch
from
c06b601 to
11d7ae5
Compare
hcvcastro
force-pushed
the
pr/master/A0
branch
from
11d7ae5 to
2817587
Compare
eszkadev
requested changes
Feb 14, 2025
| @@ -381,6 +381,8 @@ L.Control.JSDialogBuilder = L.Control.extend({ | |||
| spinfield.setAttribute('disabled', 'true'); | |||
| } | |||
|
|
|||
| spinfield.setAttribute('aria-disabled', Boolean(data.enabled)); | |||
There was a problem hiding this comment.
wrong logic: should be data.enabled === false (if not present it means it is enabled too)
There was a problem hiding this comment.
Hmm, it is a core property of every widget, it should always exist. Can you give some example to investigate?
There was a problem hiding this comment.
disabled != enabled
please reread carefully, the logic is inverted here ;)
There was a problem hiding this comment.
jaja, I see now, . Thanks
hcvcastro
force-pushed
the
pr/master/A0
branch
from
2817587 to
cb6e9a8
Compare
|
#11193 has to go in first, then please rebase. Sorry about the trouble. |
. Change-Id: Ic71df7415075523c841194902b0f7f1a6177b6b8 Signed-off-by: Henry Castro <[email protected]>
hcvcastro
force-pushed
the
pr/master/A0
branch
from
cb6e9a8 to
3a1d3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic71df7415075523c841194902b0f7f1a6177b6b8
Signed-off-by: Henry Castro [email protected]