fix(mobileWizard): stop highlighting on close #11049
Merged
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way-back-when, we deselected the toolbar button when the mobile wizard was closed. We stopped doing this during the leaflet migration because the functions we previously used to do it no longer existed (I652a163ea0c831b47ce7725ffd0f9f190a98d9bf). Instead, we can use whether the 'selected' class is on our elements in the DOM to see if they should be unchecked. That change had far more '.uncheck(...)' and '.check(...)' than I've set up here, and some of those may be necessary, but this was the bug I knew about and I didn't want to poke around with things that I wasn't completely sure where I was changing. Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: I737693f6db96c8298c07b195aa374a1bbb670108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way-back-when, we deselected the toolbar button when the mobile wizard was closed. We stopped doing this during the leaflet migration because the functions we previously used to do it no longer existed (I652a163ea0c831b47ce7725ffd0f9f190a98d9bf). Instead, we can use whether the 'selected' class is on our elements in the DOM to see if they should be unchecked.
That change had far more '.uncheck(...)' and '.check(...)' than I've set up here, and some of those may be necessary, but this was the bug I knew about and I didn't want to poke around with things that I wasn't completely sure where I was changing.
Change-Id: I737693f6db96c8298c07b195aa374a1bbb670108
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay