Style-preview: Add scroll buttons #11039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#10998 is partially done |
eszkadev
approved these changes
Jan 29, 2025
|
It should go in together with: #11040 |
Darshan-upadhyay1110
force-pushed
the
private/darshan/add-scroll-btns-in-stylepreview
branch
from
a4490ad to
75df47c
Compare
- added scroll up and down btn for stylepreview in notebookbar - added 'more' button option which is a toggle button opens the stylist Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I230ddefe3cb68dad3ba46b12eaabb12e99bad6db
Darshan-upadhyay1110
force-pushed
the
private/darshan/add-scroll-btns-in-stylepreview
branch
from
75df47c to
1b80927
Compare
6 tasks
pedropintosilva
requested changes
Jan 31, 2025
| @@ -387,7 +387,7 @@ html[data-theme='dark'] .savemodified.unotoolbutton .unobutton img { | |||
| /* Styles preview */ | |||
|
|
|||
| #stylesview { | |||
| height: 64px; | |||
| height: 66px; | |||
There was a problem hiding this comment.
I was wondering why this needed to be changed?
| border-top-right-radius: var(--border-radius); | ||
| border-bottom-right-radius: var(--border-radius); | ||
| height: 66px; | ||
| margin-left: -5px; |
There was a problem hiding this comment.
can we use margin-inline-start instead?
Comment on lines
+424
to
+425
| width: var(--btn-img-size-m) !important; | ||
| height: var(--btn-img-size-m) !important; |
There was a problem hiding this comment.
The icons need white space to breath around them. Can we use -s instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I230ddefe3cb68dad3ba46b12eaabb12e99bad6db
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay