Hide scaling handles of shapes when text cursor is visible. #11035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokaysatir
force-pushed
the
private/gokay/impress-scaling-handlers
branch
2 times, most recently
from
876ae46 to
13c71d3
Compare
Issue: * Open an Impress file and start editing a textbox. * See that handles are visible. * Try to re-scale the selected shape. * It doesn't work but the preview is shown. * When text editing is active, scaling is not enabled. * We need to hide the handles in that case. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I0ebf20270fc08f8553c1985456836711369407e4
Modify tests accordingly. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I4527ad3696df66d6a624792eaf30c6c44b79936d
gokaysatir
force-pushed
the
private/gokay/impress-scaling-handlers
branch
from
13c71d3 to
de00e84
Compare
|
Tests are passing on local. Rebased. |
eszkadev
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Change-Id: I0ebf20270fc08f8553c1985456836711369407e4
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay