-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calc: Implement column row highlight feature #11014
base: master
Are you sure you want to change the base?
Conversation
84283b8
to
6f8e8d4
Compare
To make this patch work we need this core patch : https://gerrit.libreoffice.org/c/core/+/180703 @pedropintosilva can you please help us here to add icon for I am looking into the web but haven't got anything solid yet... |
We need to create one that follows the same visual language as the others |
I commented in the core patch. It should be done more on online side (core only sends on/off). I guess something from this folder would help: https://github.com/CollaboraOnline/online/blob/master/browser/src/canvas/sections/OtherViewCellCursorSection.ts |
If there is a setting on the core side, we can save the toggle state on the core side. If there isn't a setting for this, then we may need to add one. Core side can be used to send only the toggle state, as Szymon suggested. For the drawing when toggle is on we can:
We need to test this with frozen panes, scrolled sheet, merged cells and hidden cells i think. Please let me know if this helps. Thank you. |
8d5655d
to
80d51ed
Compare
Signed-off-by: Gülşah Köse <[email protected]> Change-Id: I985b2fa7e4f59c44ca8cba00666959ff8c18d236
Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I35367e3763aa79624ec4e5ce887dc8380afd8d17
80d51ed
to
51bc4cb
Compare
Change-Id: I985b2fa7e4f59c44ca8cba00666959ff8c18d236
Summary
TODO
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay