Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calc: Implement column row highlight feature #11014

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GulsahKose
Copy link
Contributor

Change-Id: I985b2fa7e4f59c44ca8cba00666959ff8c18d236

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@Darshan-upadhyay1110
Copy link
Contributor

Darshan-upadhyay1110 commented Jan 27, 2025

To make this patch work we need this core patch : https://gerrit.libreoffice.org/c/core/+/180703

@pedropintosilva can you please help us here to add icon for lc_viewcolumnrowhighlighting.svg ? in Core there no icon preset for this function.

I am looking into the web but haven't got anything solid yet...

@pedropintosilva
Copy link
Contributor

We need to create one that follows the same visual language as the others

@eszkadev
Copy link
Contributor

I commented in the core patch. It should be done more on online side (core only sends on/off).
We draw here the highlight. @gokaysatir could give some pointers how to best implement that.

I guess something from this folder would help: https://github.com/CollaboraOnline/online/blob/master/browser/src/canvas/sections/OtherViewCellCursorSection.ts

@gokaysatir gokaysatir self-requested a review January 28, 2025 09:39
@gokaysatir
Copy link
Contributor

If there is a setting on the core side, we can save the toggle state on the core side. If there isn't a setting for this, then we may need to add one. Core side can be used to send only the toggle state, as Szymon suggested.

For the drawing when toggle is on we can:

  • Add a function into CellCursorSection.ts file, like "drawHighlight".
  • We can call the function from "onDraw" function of CellCursorSection.ts.
  • I think we can use cell cursor's width and height, and also position for the highlighting.
  • We can draw a semi-transparent rectangle that starts or overlaps with the cell cursor position and goes to the edges.
  • We can also hide the highlights when the cell cursor is hidden (if we want to). If we call the new function inside the if statement that checks the cell cursor visibility, it should be enough.

We need to test this with frozen panes, scrolled sheet, merged cells and hidden cells i think.

Please let me know if this helps.

Thank you.

GulsahKose and others added 2 commits January 31, 2025 10:25
Signed-off-by: Gülşah Köse <[email protected]>
Change-Id: I985b2fa7e4f59c44ca8cba00666959ff8c18d236
Signed-off-by: Darshan-upadhyay1110 <[email protected]>
Change-Id: I35367e3763aa79624ec4e5ce887dc8380afd8d17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

5 participants