forward-port: Mobile: Status bar dropdown is always an icon:... #10677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…width Previously the commit bellow fixed a regression related to dropdown width: 591e003 "Status bar: fix dropdown width" However there seems to be no reason to apply this fix to the mobile toolbar since we can safely conclude that the dropdowns always have the same fixed size (icons) Signed-off-by: Pedro Pinto Silva <[email protected]> Change-Id: I3733b4d736d1481a382fffb71b451b82ad77d04d
eszkadev
force-pushed
the
private/skyler/push-nlkmwpvvzsmx
branch
from
3a7f2be to
a7fa97f
Compare
pedropintosilva
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...no need for dedicated width
Previously the commit bellow fixed a regression related to dropdown width:
591e003
"Status bar: fix dropdown width"
However there seems to be no reason to apply this fix to the mobile toolbar since we can safely conclude that the dropdowns always have the same fixed size (icons)
Change-Id: I3733b4d736d1481a382fffb71b451b82ad77d04d
This is a trivial forward-port of #10639
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay