Add Lesson Container #18 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcobrunodev
requested changes
Oct 30, 2019
| border-radius: 50%; | ||
| border: 2px solid transparent; | ||
|
|
||
| font-family: Comfortaa; |
| border: 2px solid transparent; | ||
|
|
||
| font-family: Comfortaa; | ||
| font-size: 20px; |
There was a problem hiding this comment.
Use variable: --size-smallest
src/containers/LessonsCollab.svelte
Outdated
| @@ -0,0 +1,30 @@ | |||
| <script> | |||
| import { onMount } from 'svelte' | |||
marcobrunodev
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add #18
I have some to ask, what will come from a lesson?
I made the list based in a counter, as the lesson button is nothing than a button with a numbered link, with any meta or information, so i'm generating a list with just numbers to simulate a for-loop (and svelte doesn't have it)
I had done the list to scroll to the active lesson, but when I created a new component to the LessonButton the
bind:thisstopped referencing the RealDOM to reference the own dev-component, so I had to remove it, may it can be got using the HTML id attribute and the url hash.