Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lesson Container #18 #58

Closed
wants to merge 4 commits into from
Closed

Conversation

Pliavi
Copy link
Contributor

@Pliavi Pliavi commented Oct 20, 2019

Add #18

  • Add LessonButtonCollab to components
  • Add LessonsCollab to containers
  • Add scrollbar CSS to generics
  • Add --color-granite-grey color to settings/color

I have some to ask, what will come from a lesson?
I made the list based in a counter, as the lesson button is nothing than a button with a numbered link, with any meta or information, so i'm generating a list with just numbers to simulate a for-loop (and svelte doesn't have it)

I had done the list to scroll to the active lesson, but when I created a new component to the LessonButton the bind:this stopped referencing the RealDOM to reference the own dev-component, so I had to remove it, may it can be got using the HTML id attribute and the url hash.

@Pliavi Pliavi closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant