-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tr/ollama #1434
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
/describe |
PR Description updated to latest commit (7f950a3)
|
/improve |
[config] | ||
model = "ollama/qwen2.5-coder:32b" | ||
fallback_models=["ollama/qwen2.5-coder:32b"] | ||
custom_model_max_tokens=128000 # set the maximal input tokens for the model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add specific version information for the Qwen model to ensure users select a compatible version, and include installation instructions for Ollama. [general, importance: 4]
[config] | |
model = "ollama/qwen2.5-coder:32b" | |
fallback_models=["ollama/qwen2.5-coder:32b"] | |
custom_model_max_tokens=128000 # set the maximal input tokens for the model | |
[config] | |
# Ensure you have Ollama installed and the Qwen model pulled: | |
# ollama pull qwen2.5-coder:32b | |
model = "ollama/qwen2.5-coder:32b" # Requires Qwen version 2.5 or later | |
fallback_models=["ollama/qwen2.5-coder:32b"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I did not test the tools locally.
PR Type
Enhancement, Documentation
Description
Added
duplicate_prompt_examples
configuration for structured output.Enhanced prompt examples for PR review and code suggestions.
Updated documentation for Ollama and Hugging Face usage.
Improved configuration handling in
pr_agent/config_loader.py
.Changes walkthrough 📝
8 files
Added `duplicate_prompt_examples` to configuration loading.
Integrated `duplicate_prompt_examples` into code suggestions logic.
Integrated `duplicate_prompt_examples` into PR description logic.
Integrated `duplicate_prompt_examples` into PR reviewer logic.
Enhanced prompt examples for code suggestions.
Enhanced prompt examples for code suggestions reflection.
Enhanced prompt examples for PR descriptions.
Enhanced prompt examples for PR reviews.
1 files
Updated documentation for Ollama and Hugging Face models.
1 files
Added `duplicate_prompt_examples` configuration option.