feat: use qs_dart in buildUrlString
#158
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! I’m the author of qs_dart, a Dart port of qs for JavaScript.
I’ve given the
buildUrlString
utility method a thorough overhaul to boost its reliability and maintainability. Below is a summary of the key improvements:🚀 Core Enhancements
ArgumentError
for malformed or non-HTTP(S) URLsUri.parse
and basic checks - no more ad-hoc string assumptions🛠️ New Dependencies
✅ Expanded Test Coverage
Added new cases in test/utils/utils_test.dart to validate:
null
/ empty maps, empty‐string values, overriding existing keys@
,/
), spaces vs. plus signsThese tests ensure that
buildUrlString
behaves correctly across all common and edge scenarios.