Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim leading - from objective bullet points #893

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

illicitonion
Copy link
Member

We already have a checkbox acting as a bullet point, we don't need an additional - which is an artifact of being a markdown bulleted list.

We already have a checkbox acting as a bullet point, we don't need an
additional `-` which is an artifact of being a markdown bulleted list.
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-programming canceled.

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/66ccb6c70f15f0000855ecb0

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/66ccb6c7858ea80009e5ccf8
😎 Deploy Preview https://deploy-preview-893--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/66ccb6c7513a09000874827e

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-tracks canceled.

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/66ccb6c7cc124b0008418934

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/66cdddee0a0f5514a1e2f14d
😎 Deploy Preview https://deploy-preview-893--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/66ccb6c7d4e2c200081fc247

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-sdc canceled.

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/66ccb6c794535400083aa8ac

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for cyf-piscine canceled.

Name Link
🔨 Latest commit 7b7383f
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/66ccb6c714f3f2000841d090

@SallyMcGrath
Copy link
Member

I don't object but I'm curious - where is the dash appearing?

@illicitonion
Copy link
Member Author

e.g. on the Launch Apply page:

Screenshot 2024-08-27 at 12 49 14

With this PR:

Screenshot 2024-08-27 at 12 49 54

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY

@SallyMcGrath SallyMcGrath merged commit b4bd87a into main Aug 27, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the trim-objectives-bullets branch August 27, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants