Adding the ability to add ideas / recommendations to a workshops block #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-sdc canceled.
|
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
so let's instead pass through a map of related blocks
I've just removed that junk footer so we can see what we are doing as it's broken anyway
this would work for any block type you drop the partial call on to
feel free to make the nested block more fancy - it could be a slideshow, a panel viewer - whatever you feel like doing
probably also want to make all this skippable and well flagged to screenreaders
super useful to have this
this would work on all, but maybe let's just add if we find we need them
SallyMcGrath
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adding the ability to add ideas / recommendations to a workshops block. An example of this being used is in the User Data / Sprint 2 / Day Plan.
Common Content?
Common Theme?
Adding a new workshop block with the ability to pass in workshop ideas.
Issue number: #792
Org Content?
Block Type
Checklist
Who needs to know about this?
@CodeYourFuture/itp-syllabus-team @SallyMcGrath