Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to add ideas / recommendations to a workshops block #848

Merged
merged 11 commits into from
Aug 4, 2024

Conversation

moneyinthesky
Copy link
Contributor

What does this change?

Adding the ability to add ideas / recommendations to a workshops block. An example of this being used is in the User Data / Sprint 2 / Day Plan.

Common Content?

  • Block/s

Common Theme?

Adding a new workshop block with the ability to pass in workshop ideas.

  • Yes

Issue number: #792

Org Content?

Block Type

Checklist

Who needs to know about this?

@CodeYourFuture/itp-syllabus-team @SallyMcGrath

Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 109573d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/66af2e69fa1ce9000891ec38
😎 Deploy Preview https://deploy-preview-848--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for cyf-sdc canceled.

Name Link
🔨 Latest commit 109573d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/66af2e699754880008b80525

Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 109573d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/66af2e698db6e500086fdc05
😎 Deploy Preview https://deploy-preview-848--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

moneyinthesky and others added 10 commits August 3, 2024 13:23
so let's instead pass through a map of related blocks
I've just removed that junk footer so we can see what we are doing as it's broken anyway
this would work for any block type you drop the partial call on to
feel free to make the nested block more fancy - it could be a slideshow, a panel viewer - whatever you feel like doing
probably also want to make all this skippable and well flagged to screenreaders
super useful to have this
this would work on all, but maybe let's just add if we find we need them
Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, weird to self-review but this seems broadly fine and super useful in the way you have shown. Thank you SO much!

we need a new PR template for building new features so we also update documentation...

@SallyMcGrath SallyMcGrath merged commit 28388bc into main Aug 4, 2024
14 checks passed
@SallyMcGrath SallyMcGrath deleted the add_optional_workshop_ideas branch August 4, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants