Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note shortcode: Use title as title when specified #1120

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

illicitonion
Copy link
Member

What does this change?

I think this was accidentally changed in
7287ff7?

This isn't a pure revert - it sets up a fallback chain of title > type > Note rather than just title > Note

Common Content?

Trivially, sets up some example titles (as requested in #1033).

Common Theme?

Yes - changes the note shortcode.

Checklist

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/671a1f2ad7a8a60008a003a7

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/671a1f2ab1c2560008223745
😎 Deploy Preview https://deploy-preview-1120--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/671a1f2aace87200086fdf53

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/671a1f2acad77f00089253a1
😎 Deploy Preview https://deploy-preview-1120--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/671a1f2a0dbe080008aac13f
😎 Deploy Preview https://deploy-preview-1120--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/671a1f2ad971950008185ab2
😎 Deploy Preview https://deploy-preview-1120--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/671a1f2a2fdd4400081e0f61
😎 Deploy Preview https://deploy-preview-1120--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit b179da3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/671a1f2ab7137d00081bec8f

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered what you were talking about with the notes but hadn't had time to look into it! Thanks!

(But I literally just meant number the tasks in that exercise tbh)

illicitonion and others added 2 commits October 24, 2024 11:19
I think this was accidentally changed in
7287ff7?

This isn't a pure revert - it sets up a fallback chain of
title > type > Note rather than just title > Note
@illicitonion illicitonion enabled auto-merge (rebase) October 24, 2024 10:19
@illicitonion illicitonion merged commit bb16eab into main Oct 24, 2024
34 checks passed
@illicitonion illicitonion deleted the note-titles branch October 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants