Skip to content

Glasgow | ITP May -25 | Pandi Simatupang | Module-Structuring-and-Testing-Data | coursework/sprint-1 #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

PandiSimatupang
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Provided answers and comments to Sprint-1

Questions

Null

@PandiSimatupang PandiSimatupang added the Needs Review Participant to add when requesting review label Jul 10, 2025
@YoanHlebarov YoanHlebarov added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 12, 2025
Copy link

@YoanHlebarov YoanHlebarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall you have a good understanding of how the code flows. Just fix the few comments!

const age = 33;

//reassign variable age by 1 (+1)
age = age + 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would not work as we cannot reassign variables declared with const. What other ways can you think of that can allows us to do what we want?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be aware of the term Hoisting, it would allow us to access variables declared with var before they are assigned. You can read more about it in the link. What you have done is the best approach, and var should be used only when absolutely necessary, but it is worth knowing more about it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you still need to answer this one!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you still need to answer this one!

@YoanHlebarov YoanHlebarov removed the Needs Review Participant to add when requesting review label Jul 12, 2025
@YoanHlebarov YoanHlebarov added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants