London | ITP-May-25 | Anuar Duisenbek | Module-Structuring-and-Testing-Data | Sprint-3 #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,8 +8,11 @@ | |||
| // Then, write the next test! :) Go through this process until all the cases are implemented | |||
|
|
|||
| function getAngleType(angle) { | |||
| if (angle === 90) return "Right angle"; | |||
| // read to the end, complete line 36, then pass your test here | |||
| if (angle === 90) return "Right angle"; | |||
| @@ -8,7 +8,7 @@ | |||
| // write one test at a time, and make it pass, build your solution up methodically | |||
|
|
|||
| function isProperFraction(numerator, denominator) { | |||
| if (numerator < denominator) return true; | |||
| return Math.abs(numerator) < Math.abs(denominator); | |||
There was a problem hiding this comment.
Glad that you used a concise statement for this function.
How would you handle situations where the denominator is 0?
| // ====> complete with your assertion | ||
|
|
||
| // Stretch: | ||
| // What other scenarios could you test for? | ||
|
|
||
| const zeroNumerator = isProperFraction(0, 5); |
There was a problem hiding this comment.
According to a web search, a proper fraction is one where the absolute value of the numerator is smaller than the absolute value of the denominator. Like you implemented.
The numerator also has to be non-zero.
| let rank = card.slice(0, -1); | ||
| if (rank === "A") return 11; | ||
| if (rank === "K" || rank === "Q" || rank === "J" || rank === "10") return 10; | ||
| if (Number(rank) >= 2 && Number(rank) <= 9 && rank.length === 1) |
| console.log("Test failed: should have thrown an error"); | ||
| } catch (e) { | ||
| assertEquals(e.message, "Invalid card rank"); | ||
| } |
There was a problem hiding this comment.
Appreciate the innovation on this one.
| expect(getCardValue("Q♦")).toEqual(10); | ||
| }); | ||
| test("should return 10 for King of Hearts", () => { | ||
| expect(getCardValue("K♥")).toEqual(10); |
There was a problem hiding this comment.
These tests look good, there is good coverage.
| @@ -22,3 +22,6 @@ test("should count multiple occurrences of a character", () => { | |||
| // And a character char that does not exist within the case-sensitive str, | |||
| // When the function is called with these inputs, | |||
| // Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str. | |||
| test("should return 0 when there are no occurrences", () => { | |||
There was a problem hiding this comment.
We could add more test cases, for example:
Counting the number of a in aaa
Counting the number of e in excellent
| if (lastDigit === 1) return `${num}st`; | ||
| if (lastDigit === 2) return `${num}nd`; | ||
| if (lastDigit === 3) return `${num}rd`; | ||
| return `${num}th`; |
There was a problem hiding this comment.
This implementation looks nice.
|
|
||
| test("should return '4th' for 4", () => { | ||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| }); |
There was a problem hiding this comment.
Testing on 11, 12, 13 would also be good for coverage.
|
|
||
| // case: Negative Count: | ||
| // Given a target string str and a negative integer count, | ||
| // When the repeat function is called with these inputs, | ||
| // Then it should throw an error or return an appropriate error message, as negative counts are not valid. | ||
| test("should throw error for negative count", () => { |
Amundeep-Dhaliwal
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
This PR includes my responses and code to questions in the: Key Implement, Mandatory Rewrite, Mandatory Practice and the Stretch Investigate files.
Questions
Ask any questions you have for your reviewer.