Skip to content

London|May 2025|Alexandru Pocovnicu|Coursework/sprint 3 #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Sprint-3/1-key-implement/1-get-angle-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@

function getAngleType(angle) {
if (angle === 90) return "Right angle";
if(angle<90) return "Acute angle";
if(angle>90 && angle<180) return "Obtuse angle"
if(angle===180) return "Straight angle"
if (angle>180 && angle<=360) return "Reflex angle"
// read to the end, complete line 36, then pass your test here
}

Expand Down Expand Up @@ -43,14 +47,19 @@ assertEquals(acute, "Acute angle");
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
const obtuse = getAngleType(120);
assertEquals(obtuse,"Obtuse angle")
// ====> write your test here, and then add a line to pass the test in the function above

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"
// ====> write your test here, and then add a line to pass the test in the function above
const straight=getAngleType(180)
assertEquals(straight,"Straight angle")

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
// ====> write your test here, and then add a line to pass the test in the function above
// ====> write your test here, and then add a line to pass the test in the function above
const reflex=getAngleType(230)
assertEquals(reflex,"Reflex angle")
13 changes: 12 additions & 1 deletion Sprint-3/1-key-implement/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@
// write one test at a time, and make it pass, build your solution up methodically

function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
if (isNaN(numerator) || isNaN(denominator)) return NaN;
if (Math.abs(numerator) < Math.abs(denominator)) return true;
if(Math.abs(numerator)>Math.abs(denominator)) return false;
if(Math.abs(numerator)===Math.abs(denominator)) return false;

}

// here's our helper again
Expand Down Expand Up @@ -40,14 +44,21 @@ assertEquals(improperFraction, false);
// target output: true
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
const negativeFraction = isProperFraction(-4, 7);
assertEquals(negativeFraction,true)
// ====> complete with your assertion

// Equal Numerator and Denominator check:
// Input: numerator = 3, denominator = 3
// target output: false
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
const equalFraction = isProperFraction(3, 3);
assertEquals(equalFraction,false)
// ====> complete with your assertion

// Stretch:
// What other scenarios could you test for?
const notANumber=isProperFraction(NaN,3)
console.assert(isNaN(notANumber), `Expected NaN, got ${notANumber}`);

const notANumber2 = isProperFraction(3, NaN);
console.assert(isNaN(notANumber2), `Expected NaN, got ${notANumber2}`);
11 changes: 11 additions & 0 deletions Sprint-3/1-key-implement/3-get-card-value.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@
// write one test at a time, and make it pass, build your solution up methodically
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
function getCardValue(card) {
let rank=card.slice(0,-1);
if (rank === "A") return 11;
if(rank>=2 && rank<10)return Number(rank);
if(rank==="10"|| rank==="J" || rank==="Q" || rank==="K") return 10;
else return "Invalid card rank"
}

// You need to write assertions for your function to check it works in different cases
Expand All @@ -33,19 +37,26 @@ assertEquals(aceofSpades, 11);
// When the function is called with such a card,
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
const fiveofHearts = getCardValue("5♥");
assertEquals(fiveofHearts,5)
// ====> write your test here, and then add a line to pass the test in the function above

// Handle Face Cards (J, Q, K):
// Given a card with a rank of "10," "J," "Q," or "K",
// When the function is called with such a card,
// Then it should return the value 10, as these cards are worth 10 points each in blackjack.
const faceCards = getCardValue("10♥", "J♥", "Q♥", "K♥");
assertEquals(faceCards,10)

// Handle Ace (A):
// Given a card with a rank of "A",
// When the function is called with an Ace,
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
const aceofHeart = getCardValue("A♥");
assertEquals(aceofHeart, 11);

// Handle Invalid Cards:
// Given a card with an invalid rank (neither a number nor a recognized face card),
// When the function is called with such a card,
// Then it should throw an error indicating "Invalid card rank."
const invalidCard=getCardValue("B")
assertEquals(invalidCard,"Invalid card rank")
4 changes: 4 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
function getAngleType(angle) {
if (angle === 90) return "Right angle";
if (angle < 90) return "Acute angle";
if (angle > 90 && angle < 180) return "Obtuse angle";
if (angle === 180) return "Straight angle";
if (angle > 180 && angle <= 360) return "Reflex angle";
// replace with your completed function from key-implement

}
Expand Down
28 changes: 16 additions & 12 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,22 @@ test("should identify right angle (90°)", () => {
// REPLACE the comments with the tests
// make your test descriptions as clear and readable as possible

// Case 2: Identify Acute Angles:
// When the angle is less than 90 degrees,
// Then the function should return "Acute angle"

// Case 3: Identify Obtuse Angles:
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
test("should identify acute angle(45°)",()=>{
expect(getAngleType(45)).toEqual("Acute angle");
});


test("should indentify obtuse angle(120°)",()=>{
expect(getAngleType(120)).toEqual("Obtuse angle")
});


test("should identify straight angle(180°)",()=>{
expect(getAngleType(180)).toEqual("Straight angle")
});

// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
test("should identify reflex angle(230°)",()=>{
expect(getAngleType(230)).toEqual("Reflex angle")
});
6 changes: 5 additions & 1 deletion Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
if (isNaN(numerator) || isNaN(denominator)) return NaN;
if (Math.abs(numerator) < Math.abs(denominator)) return true;
if (Math.abs(numerator) > Math.abs(denominator)) return false;
if (Math.abs(numerator) === Math.abs(denominator)) return false;

// add your completed function from key-implement here
}

Expand Down
12 changes: 12 additions & 0 deletions Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,19 @@ test("should return true for a proper fraction", () => {
});

// Case 2: Identify Improper Fractions:
test("should return false for improper fraction",()=>{
expect(isProperFraction(5,2)).toEqual(false);
})

// Case 3: Identify Negative Fractions:
test("should return true for negative fraction",()=>{
expect(isProperFraction(-4,7)).toEqual(true);
})

// Case 4: Identify Equal Numerator and Denominator:
test("should return false for equal numerator and denominator",()=>{
expect(isProperFraction(3,3)).toEqual(false);
})
test("should return NaN for non-numbers",()=>{
expect(isProperFraction(3,NaN)).toEqual(NaN);
})
7 changes: 6 additions & 1 deletion Sprint-3/2-mandatory-rewrite/3-get-card-value.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
function getCardValue(card) {
// replace with your code from key-implement
return 11;
let rank=card.slice(0,-1);
if (rank === "A") return 11;
if(rank>=2 && rank<10)return Number(rank);
if(rank==="10"|| rank==="J" || rank==="Q" || rank==="K") return 10;
else return "Invalid card rank"

}
module.exports = getCardValue;
15 changes: 15 additions & 0 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,21 @@ test("should return 11 for Ace of Spades", () => {
});

// Case 2: Handle Number Cards (2-10):
test("should return 5 for 5 of heart",()=>{
const fiveofHearts = getCardValue("5♥");
expect(fiveofHearts).toEqual(5);
})
// Case 3: Handle Face Cards (J, Q, K):
test("should return 10 for J of spades",()=>{
const jofSpades=getCardValue("J♠");
expect(jofSpades).toEqual(10);
});
// Case 4: Handle Ace (A):
test("should return 11 for Ace of Heart",()=>{
const aceofHeart = getCardValue("A♥");
expect(aceofHeart).toEqual(11);
})
// Case 5: Handle Invalid Cards:
test("should return invalid cards for anything else",()=>{
expect(getCardValue("l")).toBe("Invalid card rank")
})
4 changes: 2 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
return stringOfCharacters.split("").filter((char)=>char===findCharacter).length
}

//console.log(countChar("heello","l"))
module.exports = countChar;
6 changes: 6 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
// And a character char that does not exist within the case-sensitive str,
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
test("should return 0 for no occurrences",()=>{
const str = "papadie";
const char = "o";
const count = countChar(str, char);
expect(count).toEqual(0);
})
18 changes: 17 additions & 1 deletion Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
function getOrdinalNumber(num) {
return "1st";
if (isNaN(num)) {
return NaN;
}
if(num>=11 && num<=13){
return num+"th"
}

if(num===1){
return num+"st"
}
if (num === 2) {
return num + "nd";
}
if (num === 3) {
return num + "rd";
}
return (num)+"th"
}

module.exports = getOrdinalNumber;
30 changes: 30 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,33 @@ const getOrdinalNumber = require("./get-ordinal-number");
test("should return '1st' for 1", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
});
// Case 2: Identify the ordinal number for 2
// When the number is 2,
// Then the function should return "2nd"
test("should return '2nd' for 2", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
});
// Case 3: Identify the ordinal number for 3
// When the number is 3,
// Then the function should return "3rd"
test("should return '3rd' for 3", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
});
// Case 4: Identify the ordinal number for 11,12,13
// When the number is 11,12,13,
// Then the function should return "11th","12th","13th"
test("should return '11th' for 11", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
});
// Case 5: Identify the ordinal number for 6
// When the number is 6
// Then the function should return "6th"
test("should return '6th' for 6", () => {
expect(getOrdinalNumber(6)).toEqual("6th");
});
// Case 6: Identify NaN
// When the number is NaN
// Then the function should return "NaN"
test("should return 'NaN' for NaN", () => {
expect(isNaN(getOrdinalNumber(NaN))).toEqual(true);
});
9 changes: 6 additions & 3 deletions Sprint-3/3-mandatory-practice/implement/repeat.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
function repeat() {
return "hellohellohello";
function repeat(str,count) {
if(count<0){
return "negative number"
}
return str.repeat(count);
}

//console.log(repeat("hello",3))
module.exports = repeat;
19 changes: 19 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/repeat.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,32 @@ test("should repeat the string count times", () => {
// Given a target string str and a count equal to 1,
// When the repeat function is called with these inputs,
// Then it should return the original str without repetition, ensuring that a count of 1 results in no repetition.
test("should repeat the string count times", () => {
const str = "hello";
const count = 1;
const repeatedStr = repeat(str, count);
expect(repeatedStr).toEqual("hello");
});

// case: Handle Count of 0:
// Given a target string str and a count equal to 0,
// When the repeat function is called with these inputs,
// Then it should return an empty string, ensuring that a count of 0 results in an empty output.
test("should repeat the string count times", () => {
const str = "hello";
const count = 0;
const repeatedStr = repeat(str, count);
expect(repeatedStr).toEqual("");
});


// case: Negative Count:
// Given a target string str and a negative integer count,
// When the repeat function is called with these inputs,
// Then it should throw an error or return an appropriate error message, as negative counts are not valid.
test("should repeat the string count times", () => {
const str = "hello";
const count = -1;
const repeatedStr = repeat(str, count);
expect(repeatedStr).toEqual("negative number");
});
18 changes: 13 additions & 5 deletions Sprint-3/4-stretch-investigate/password-validator.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
function passwordValidator(password) {
return password.length < 5 ? false : true
}


module.exports = passwordValidator;

function passwordValidator(password,previousPasswords=[]) {
if (previousPasswords.includes(password)) return false;
const hasMinLength = password.length >= 5;
const hasUpper = /[A-Z]/.test(password);
const hasLower = /[a-z]/.test(password);
const hasNumber = /[0-9]/.test(password);
const hasSymbol = /[!#$%.*&]/.test(password);

return hasMinLength && hasUpper && hasLower && hasNumber && hasSymbol;
}

module.exports = passwordValidator;
Loading