Skip to content

SA|ITP MAY 2025|INNOCENT NIWATWINE| Structuring and Data Testing| Sprint 3 #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sprint-3/1-key-implement/1-get-angle-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ function getAngleType(angle) {
if (angle === 90) return "Right angle";
// read to the end, complete line 36, then pass your test here
}
function getAngleType(angle) {
if (angle === 90) return "Right angle";
if (angle < 90) return "Acute angle";
if (angle > 90 && angle < 180) return "Obtuse angle";
if (angle === 180) return "Straight angle";
if (angle > 180 && angle < 360) return "Reflex angle";
else if (angle > 180 && angle < 360) return "Reflex angle";
}

// we're going to use this helper function to make our assertions easier to read
// if the actual output matches the target output, the test will pass
Expand Down Expand Up @@ -53,4 +61,6 @@ const obtuse = getAngleType(120);
// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
// ====> write your test here, and then add a line to pass the test in the function above
// ====> write your test here, and then add a line to pass the test in the function above
const reflex = getAngleType(270);
assertEquals(reflex, "Reflex angle");
15 changes: 13 additions & 2 deletions Sprint-3/1-key-implement/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@
// write one test at a time, and make it pass, build your solution up methodically

function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
if (numerator < denominator) {
return true;
} else if (numerator >= denominator) {
return false;
} else if (numerator === 1) {
return true;
}
}


// here's our helper again
function assertEquals(actualOutput, targetOutput) {
Expand Down Expand Up @@ -39,15 +46,19 @@ assertEquals(improperFraction, false);
// Input: numerator = -4, denominator = 7
// target output: true
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.

const negativeFraction = isProperFraction(-4, 7);
// ====> complete with your assertion
assertEquals(negativeFraction, true);

// Equal Numerator and Denominator check:
// Input: numerator = 3, denominator = 3
// target output: false
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
const equalFraction = isProperFraction(3, 3);
// ====> complete with your assertion

assertEquals(equalFraction, false);
// Stretch:
// What other scenarios could you test for?
const unitFraction = isProperFraction(1, 9);
assertEquals(unitFraction, true);
24 changes: 19 additions & 5 deletions Sprint-3/1-key-implement/3-get-card-value.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@
// write one test at a time, and make it pass, build your solution up methodically
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers
function getCardValue(card) {
if (rank === "A") return 11;
const faceCards = ["10", "J", "Q", "K"];
const rank = card.slice(0, -1);
if (rank === "A") return 11;
if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 9)
return Number(rank);
if (faceCards.includes(rank)) return 10;
throw new Error("Invalid card rank");
}


// You need to write assertions for your function to check it works in different cases
// we're going to use this helper function to make our assertions easier to read
// if the actual output matches the target output, the test will pass
Expand All @@ -25,7 +32,7 @@ function assertEquals(actualOutput, targetOutput) {
// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
// When the function getCardValue is called with this card string as input,
// Then it should return the numerical card value
const aceofSpades = getCardValue("A♠");
const numberCards = getCardValue("5♣");
assertEquals(aceofSpades, 11);

// Handle Number Cards (2-10):
Expand All @@ -34,18 +41,25 @@ assertEquals(aceofSpades, 11);
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
const fiveofHearts = getCardValue("5♥");
// ====> write your test here, and then add a line to pass the test in the function above

assertEquals(numberCards, 5);
// Handle Face Cards (J, Q, K):
// Given a card with a rank of "10," "J," "Q," or "K",
// When the function is called with such a card,
// Then it should return the value 10, as these cards are worth 10 points each in blackjack.

const faceCards = getCardValue("Q♥");
assertEquals(faceCards, 10);
// Handle Ace (A):
// Given a card with a rank of "A",
// When the function is called with an Ace,
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.

const ace = getCardValue("A♠");
assertEquals(ace, 11);
// Handle Invalid Cards:
// Given a card with an invalid rank (neither a number nor a recognized face card),
// When the function is called with such a card,
// Then it should throw an error indicating "Invalid card rank."
try {
getCardValue("sevenofclubs");
} catch (error) {
assertEquals(error.message, "Invalid card rank");
}
9 changes: 9 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
function getAngleType(angle) {
if (angle === 90) return "Right angle";
// replace with your completed function from key-implement
if (angle === 90) return "Right angle";
if (angle < 90) return "Acute angle";
if (angle > 90 && angle < 180) return "Obtuse angle";
if (angle === 180) return "Straight angle";
if (angle > 180 && angle < 360) return "Reflex angle";
else if (angle > 180 && angle < 360) return "Reflex angle";

return "Revolution";

}

Expand All @@ -11,6 +19,7 @@ function getAngleType(angle) {




// Don't get bogged down in this detail
// Jest uses CommonJS module syntax by default as it's quite old
// We will upgrade our approach to ES6 modules in the next course module, so for now
Expand Down
15 changes: 15 additions & 0 deletions Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ test("should identify right angle (90°)", () => {

// REPLACE the comments with the tests
// make your test descriptions as clear and readable as possible
test("should identify acute angle (less than 90°)", () => {
expect(getAngleType(70)).toEqual("Acute angle");
});

// Case 2: Identify Acute Angles:
// When the angle is less than 90 degrees,
Expand All @@ -14,11 +17,23 @@ test("should identify right angle (90°)", () => {
// Case 3: Identify Obtuse Angles:
// When the angle is greater than 90 degrees and less than 180 degrees,
// Then the function should return "Obtuse angle"
test("should indentify obtuse angle (greater than 90°)", () => {
expect(getAngleType(120)).toEqual("Obtuse angle");
});



// Case 4: Identify Straight Angles:
// When the angle is exactly 180 degrees,
// Then the function should return "Straight angle"

test("should indentify straight angle (180°)", () => {
expect(getAngleType(120)).toEqual("Straight angle");
});

// Case 5: Identify Reflex Angles:
// When the angle is greater than 180 degrees and less than 360 degrees,
// Then the function should return "Reflex angle"
test("should indentify reflex angle (greater than 180°)", () => {
expect(getAngleType(260)).toEqual("Reflex Angle");
});
2 changes: 2 additions & 0 deletions Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
function isProperFraction(numerator, denominator) {
if (numerator < denominator) return true;
// add your completed function from key-implement here
if (numerator >= denominator) return false;
// add your completed function from key-implement here
}

Expand Down
12 changes: 11 additions & 1 deletion Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,17 @@ test("should return true for a proper fraction", () => {
});

// Case 2: Identify Improper Fractions:

test("should return false for a improper fraction", () => {
expect(isProperFraction(5, 2)).toEqual(false);
});
// Case 3: Identify Negative Fractions:

test("should return true for a negative fraction", () => {
expect(isProperFraction(-4, 7)).toEqual(true);
});

// Case 4: Identify Equal Numerator and Denominator:

test("should return true for a equal fraction", () => {
expect(isProperFraction(3, 3)).toEqual(false);
});
9 changes: 7 additions & 2 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
function getCardValue(card) {
// replace with your code from key-implement
return 11;
const faceCards = ["10", "J", "Q", "K"];
const rank = card.slice(0, -1);
if (rank === "A") return 11;
if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 9)
return Number(rank);
if (faceCards.includes(rank)) return 10;
throw new Error("Invalid card rank");
}
module.exports = getCardValue;
25 changes: 21 additions & 4 deletions Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,28 @@
const getCardValue = require("./3-get-card-value");

test("should return 11 for Ace of Spades", () => {
const aceofSpades = getCardValue("A♠");
expect(aceofSpades).toEqual(11);
});
const aceofSpades = getCardValue("A♠");
expect(aceofSpades).toEqual(11);
});

// Case 2: Handle Number Cards (2-10):
test("should return the number value of Number cards", () => {
const numberCards = getCardValue("3♦");
expect(numberCards).toEqual(3);
});
// Case 3: Handle Face Cards (J, Q, K):
test("should return 10 for Face cards", () => {
const faceCards = getCardValue("Q♣");
expect(faceCards).toEqual(10);
});

// Case 4: Handle Ace (A):
test("should return 11 for Ace cards", () => {
const aceCards = getCardValue("A♣");
expect(aceCards).toEqual(11);
});
// Case 5: Handle Invalid Cards:
test("should return Invalid card rank for Invalid cards", () => {
expect(() => {
getCardValue("Z♥");
}).toThrow("Invalid card rank");
});
2 changes: 1 addition & 1 deletion Sprint-3/3-mandatory-practice/implement/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
return stringOfCharacters.split(findCharacter).length - 1;
}

module.exports = countChar;
6 changes: 6 additions & 0 deletions Sprint-3/3-mandatory-practice/implement/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => {
// And a character char that does not exist within the case-sensitive str,
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str.
test("should count no occurences of a character", () => {
const str = "shannon";
const char = "e";
const count = countChar(str, char);
expect(count).toEqual(0);
});
16 changes: 14 additions & 2 deletions Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
function getOrdinalNumber(num) {
return "1st";
}
const lastDigits = num % 10;
const lastTwoDigits = num % 100;

if (lastTwoDigits >= 11 && lastTwoDigits <= 13) return num + "th";
if (lastDigits === 1) {
return num + "st";
} else if (lastDigits === 2) {
return num + "nd";
} else if (lastDigits === 3) {
return num + "rd";
} else {
return num + "th";
}
}

module.exports = getOrdinalNumber;
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,24 @@ const getOrdinalNumber = require("./get-ordinal-number");

test("should return '1st' for 1", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
});
});

test("should return '2nd' for 2", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
});

test("should return '3rd' for 3", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
});

test("should return 11th for 11", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
});

test("should return 19th for 19", () => {
expect(getOrdinalNumber(19)).toEqual("19th");
});

test("should return 24th for 24", () => {
expect(getOrdinalNumber(24)).toEqual("24th");
});
12 changes: 8 additions & 4 deletions Sprint-3/3-mandatory-practice/implement/repeat.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
function repeat() {
return "hellohellohello";
}

function repeat(str, count) {
if (count === 0) return "";
if (count < 0) {
throw new Error("Not Allowed");
} else {
return str.repeat(count);
}
}
module.exports = repeat;
20 changes: 16 additions & 4 deletions Sprint-3/3-mandatory-practice/implement/repeat.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,31 @@ test("should repeat the string count times", () => {
const count = 3;
const repeatedStr = repeat(str, count);
expect(repeatedStr).toEqual("hellohellohello");
});

});
// case: handle Count of 1:
// Given a target string str and a count equal to 1,
// When the repeat function is called with these inputs,
// Then it should return the original str without repetition, ensuring that a count of 1 results in no repetition.

test("should return original string", () => {
const str = "word";
const count = 1;
const repeatedStr = repeat(str, count);
expect(repeatedStr).toEqual("word");
});
// case: Handle Count of 0:
// Given a target string str and a count equal to 0,
// When the repeat function is called with these inputs,
// Then it should return an empty string, ensuring that a count of 0 results in an empty output.

test("should return empty string ", () => {
const str = "shannon";
const count = 0;
const repeatedStr = repeat(str, count);
expect(repeatedStr).toEqual("");
});
// case: Negative Count:
// Given a target string str and a negative integer count,
// When the repeat function is called with these inputs,
// Then it should throw an error or return an appropriate error message, as negative counts are not valid.
test("should return error", () => {
expect(() => repeat("hello", -4)).toThrow("Not Allowed");
});