Skip to content

Glasgow | May-2025 | Salah Ahmed| Sprint-3 #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Glasgow | May-2025 | Salah Ahmed| Sprint-3 #634

wants to merge 45 commits into from

Conversation

avatarit
Copy link

@avatarit avatarit commented Jul 3, 2025

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

All the issues have been solved in Sprint 3

Millena28 and others added 30 commits February 21, 2025 14:43
@Millena28
have done my key-implement exercise
41faaac
@Millena28
done the mandatory-rewrite
fb392b3
@Millena28
Done the mandatory-practice
52148a6
@Millena28
Done stretch investigate and implemented new card-validator file
4d0497e
@Millena28
done ALL
13220cd
@Millena28
made some corrections from review
396094b
@avatarit
Merge branch 'CodeYourFuture:coursework/sprint-3' into coursework/spr…
f3b70e8 
…int-3
@avatarit
Implement angle type identification in getAngleType function
8ca4e8e
@avatarit
Remove placeholder comments for missing tests in getAngleType function
a9c9341
@avatarit
Refactor getAngleType function for improved readability and consistency
b1b2078
@avatarit
Add assertions for zero numerator check in isProperFraction function
78e3a52
@avatarit
Fix formatting inconsistencies in angle type assertions for clarity
c75235c
@avatarit
Refactor getCardValue function to improve card rank extraction and va…
39aad2d 
…lidation logic
@avatarit
Refactor getAngleType function to streamline angle classification logic
0d2e786
@avatarit
Refactor getCardValue function for improved clarity and error handling
ef3385f
@avatarit
Update package-lock.json to reflect changes in package names and vers…
f381483 
…ions
@avatarit
Refactor isProperFraction function and update tests for accuracy
49bcbfe
@avatarit
Remove unnecessary files: package.json, readme.md, and image assets
5774458
@avatarit
Add tests for getCardValue function to validate card value retrieval …
9226863 
…and error handling
@avatarit
Add getCardValue function to retrieve card values with error handling
e8bdd72
@avatarit
Add tests for getAngleType function to validate angle identification
03fd47d
@avatarit
Implement getAngleType function with angle classification and corresp…
61cdb3e 
…onding tests
@avatarit
Implement isProperFraction function with comprehensive test cases
41d94fc
@avatarit
Implement isProperFraction function to evaluate proper fractions
0f70f77
@avatarit
Refactor code structure for improved readability and maintainability
830b5e4
@avatarit
Fix the code of get angle
b500e15
@avatarit
Remove unnecessary blank line in isProperFraction.js
e931299
@avatarit
fixed the code issue
315ab1a
@avatarit
Remove unnecessary blank line at the beginning of get-card-value.js
aae7d84
@avatarit
Refactor angle type function to improve clarity and return default va…
2fd86de 
…lue for unknown angles
avatarit added 15 commits July 3, 2025 00:42
@avatarit
Refactor angle type tests for clarity by removing redundant comments
c693e17
@avatarit
fix the issue in the code
4330f25
@avatarit
Update isProperFraction test file
d92d35c
@avatarit
Refactor getCardValue function for improved readability by adjusting …
c45f222 
…indentation and formatting
@avatarit
Refactor test cases for getCardValue function by reorganizing comment…
388622f 
…s for better clarity
@avatarit
Update countChar function
51997e1
@avatarit
Fix formatting of comment in count.test.js for consistency
88e292d
@avatarit
Refactor getOrdinalNumber function for improved readability by adjust…
7829d7e 
…ing indentation
@avatarit
update ordinal-number.test.js for improved readability
e924d5d
@avatarit
Fix formatting
475029a
@avatarit
implement the code
65bcde5
@avatarit
Refactor isValidCreditCard function for improved readability and cons…
fef80b8 
…istency
@avatarit
The questions have been answerd
9549f29
@avatarit
fix passwordValidator function
97d365f
@avatarit
update the file
35c9171
@avatarit avatarit added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Participant to add when requesting review labels Jul 3, 2025
@avatarit avatarit mentioned this pull request Jul 3, 2025
Closed
@jenny-alexander jenny-alexander self-requested a review July 10, 2025 13:55
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jul 10, 2025
@avatarit avatarit mentioned this pull request Jul 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenny-alexander jenny-alexander Awaiting requested review from jenny-alexander

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avatarit @jenny-alexander @Millena28