London | May-2025 | Fatima_Zohra_Belkedari | Module Structuring and Testing Data | Sprint. 3 #629

Farah-Stu · 2025-06-30T23:55:50Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Sprint-3/2-mandatory-rewrite/1-get-angle-type.js

cjyuan · 2025-07-08T02:43:37Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+  const number = Number(rank);
+  if (number >= 2 && number <= 10) return number;


In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "00_02".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("00_02♠");

I tried and used chat gpt but I dont't want to copy and paste without understanding. I would appreciate if you could explain to me.

I run the code and it did't return what was expected with the functions above.

Why not update the code to throw error with the argument is one of these?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("00_02♠");

cjyuan · 2025-07-08T02:44:47Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 10 for Jack of Diamonds", () => {
+    expect(getCardValue ("J")).toEqual(10);
+});
+
+test("should return 10 for Queen of Clubs", () => {
+    expect(getCardValue("Q")).toEqual(10);
+});
+
+test("should return 10 for King of Spades", () => {
+    expect(getCardValue("K")).toEqual(10);
+});
+


We could combine these tests under the category "should return 10 for face cards (J, Q, K)" and check all three ranks J, Q, K).

Ok.
test("should return 10 for face cards J,Q,K", () => {
["J" ,"Q" ,"K"] .forEach(rank) => {
expect(getCardValue(rank)).toEqual (10);
});
});

The approach you suggested in your previous comment works. Why not update the code as well?

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

cjyuan · 2025-07-08T02:53:13Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

+    const strNum= num.toString();
+    if(strNum.slice(-2)==="11") {
+        return strNum + "th";
+    }
+if(strNum.slice(-2)==="12") {
+        return strNum + "th";
+    }   
+if(strNum.slice(-2)==="13") {
+        return strNum + "th";
+    }
+if(strNum.slice(-1)==="1") {
+        return strNum + "st";
+    }
+if(strNum.slice(-1)==="2") {
+        return strNum + "nd";
+    }
+if(strNum.slice(-1)==="3") {
+        return strNum + "rd";
+    }
+


If num is an integer, we could also use % to extract the last one or two digits from its value.

What should the function return when num is 10, 15, or 124?

If we use the number%10 we will get the last digit. In this case :
10 % 10 = 0
15 % 10 = 5
124 % 10 = 4

What does your function return when num is 10, 15, or 124?

number will return the remainder

10 % 10 = 0
15 % 10 = 5
124 % 10 = 4

cjyuan · 2025-07-08T02:53:37Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

+    test("should return '2nd' for 2", () => {
+        expect(getOrdinalNumber(2)).toEqual("2nd");
+    });


To ensure thorough testing, we need broad scenario coverage. Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories. Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

Can you update the tests in this script so that they can cover all valid integers?

test("append 'st' to numbers ending in 1" , () => {
expect(getOrdinalNumber(1)).toEqual("1st");
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(121)).toEqual("121st");
});

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect(getOrdinalNumber(2)).toEqual("2nd"); expect(getOrdinalNumber(22)).toEqual("22nd"); expect(getOrdinalNumber(132)).toEqual("132nd"); }); test("append 'rd' to numbers ending in 3 , except those ending in 13", () => { expect(getOrdinalNumber(23)).toEqual("23rd"); expect(getOrdinalNumber(13)).toEqual("13th"); expect(getOrdinalNumber(3)).toEqual("3rd"); }); test("should return '11th' for 11", () => { expect(getOrdinalNumber(11)).toEqual("11th"); });

Sprint-3/3-mandatory-practice/implement/repeat.test.js

cjyuan

Some of the code could still use some improvement.

cjyuan · 2025-07-12T08:19:51Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

        expect(getOrdinalNumber(23)).toEqual("23rd");
+        expect(getOrdinalNumber(13)).toEqual("13th");


"except those ending in 13".

Numbers ending in 12, and 13 could be placed together with numbers ending in 11 in the same category.

cjyuan · 2025-07-12T08:26:07Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

+    const strNum= num.toString();
+    if(strNum.slice(-2)==="11") {
+        return strNum + "th";
+    }
+if(strNum.slice(-2)==="12") {
+        return strNum + "th";
+    }   
+if(strNum.slice(-2)==="13") {
+        return strNum + "th";
+    }
+if(strNum.slice(-1)==="1") {
+        return strNum + "st";
+    }
+if(strNum.slice(-1)==="2") {
+        return strNum + "nd";
+    }
+if(strNum.slice(-1)==="3") {
+        return strNum + "rd";
+    }
+


What does your function return when num is 10, 15, or 124?

cjyuan · 2025-07-12T08:30:39Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.js

+  const number = Number(rank);
+  if (number >= 2 && number <= 10) return number;


Why not update the code to throw error with the argument is one of these?

getCardValue("0x02♠"); getCardValue("2.1♠"); getCardValue("00_02♠");

cjyuan · 2025-07-12T08:31:58Z

Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js

+test("should return 10 for Jack of Diamonds", () => {
+    expect(getCardValue ("J")).toEqual(10);
+});
+
+test("should return 10 for Queen of Clubs", () => {
+    expect(getCardValue("Q")).toEqual(10);
+});
+
+test("should return 10 for King of Spades", () => {
+    expect(getCardValue("K")).toEqual(10);
+});
+


The approach you suggested in your previous comment works. Why not update the code as well?

cjyuan

get-ordinal-number.js and get-ordinal-number.test.js can still use some improvement.

All other changes look good.

cjyuan · 2025-07-12T13:48:01Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js

+
+    test("should return '11th' for 11 , 12, 13", () => {
+        expect(getOrdinalNumber(11)).toEqual("11th");
+        expect(getOrdinalNumber(12)).toEqual("12th");
+        expect(getOrdinalNumber(13)).toEqual("13th");   
+    });     


Can you include this test to the script and then check if your function can pass this test:

// Replace _______ by the value you expected test("should append '__' to number ending in 0, 4-9", () => { expect(getOrdinalNumber(124)).toEqual( _______ ); expect(getOrdinalNumber(10)).toEqual( _______ ); expect(getOrdinalNumber(99)).toEqual( _______ ); });

Farah-Stu added 17 commits June 27, 2025 23:56

updating angle type.js

696bb42

fixing the proper fraciton.js

4cc5106

updating card value

22cab74

update card value

ed21e9d

update angle type.test

4d9bc3b

adding assertEqual line

8f7c8a6

updating proper fraction file

27e36c5

updating the file

a97c923

updating the proper fraction test file

cc9d7dc

updating card file

bfee299

updating card test file

8f9221a

update count file

d6a385f

update count.test.js

0c51d93

updating ordinal num file

9c6607c

update ordinal num file test

da6f74f

update repeat file

b15ce67

update repeat test file

401a0d1

Farah-Stu added the Needs Review Participant to add when requesting review label Jun 30, 2025

Farah-Stu mentioned this pull request Jul 3, 2025

London ITP MAY 2025 |Structuring and Testing Data | Fatima Zohra Belkedari | Step 2 Farah-Stu/My-Coursework-Planner#51

Open

cjyuan reviewed Jul 8, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 8, 2025

Farah-Stu added 7 commits July 11, 2025 16:00

updating and returnig a valid message to the function

d25287f

returning a valid message to the code

ea3514b

matching the description in the test file

22db2cc

updating

77294d9

updating and testing numbers

6c4aa13

updating file.js

b0c9c31

updadting the test file

3000184

Farah-Stu removed the Reviewed Volunteer to add when completing a review label Jul 11, 2025

Farah-Stu added the Needs Review Participant to add when requesting review label Jul 11, 2025

cjyuan reviewed Jul 12, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 12, 2025

Farah-Stu added 4 commits July 12, 2025 10:16

updating the code

96eb260

updating the card value code

19e006e

updating the code with invalid card rank

037bc34

updating the file

535e4ba

Farah-Stu added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 12, 2025

cjyuan reviewed Jul 12, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 12, 2025

		const number = Number(rank);
		if (number >= 2 && number <= 10) return number;

		expect(getOrdinalNumber(23)).toEqual("23rd");
		expect(getOrdinalNumber(13)).toEqual("13th");

Uh oh!

London | May-2025 | Fatima_Zohra_Belkedari | Module Structuring and Testing Data | Sprint. 3 #629

Are you sure you want to change the base?

London | May-2025 | Fatima_Zohra_Belkedari | Module Structuring and Testing Data | Sprint. 3 #629

Conversation

Farah-Stu commented Jun 30, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Jul 12, 2025 •

edited

Loading

cjyuan Jul 12, 2025 •

edited

Loading