Module-Structuring-and-Testing-Data sprint2 Nurzat Nurdinova #622
Conversation
nurzatpro
changed the title
nurzatpro
added
Needs Review
|
It looks like the PR template wasn’t filled out. Could you please update the description accordingly? |
There was a problem hiding this comment.
-
I think you missed answering the questions in
Sprint-2/4-mandatory-interpret/time-format.js. -
Why not practice "committing files one by one, on purpose, and for a reason"?
In VSCode, you can select which file to stage, and commit only the staged file.
See: https://www.youtube.com/watch?v=z5jZ9lrSpqk&t=705 (At around 12:50 minute marker, the video shows how to stage a single file). (You can practice this in future PRs)
| squareHeight =height * height; | ||
| bmi = weight / squareHeight; | ||
| return bmi.0toFixed(1); | ||
|
|
There was a problem hiding this comment.
-
What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect it to return? -
There is a syntax error at line 20.
-
Did you forget to declare
squareHeightandbmi?
| function upperSnakeCase(str) { | ||
| return (upperSnakeCase = str.replaceAll(" ", "_").toUpperCase()); | ||
| } | ||
| console.log(upperSnakeCase("Congratulations having a boy! 🎉")); |
There was a problem hiding this comment.
There is a bug at line 18.
If you call upperSnakeCase() multiple times in the same script, you will discover the bug.
|
|
||
| function toPounds(kg) { | ||
| const pounds =kg *2.20462; | ||
| return pounds.toFixed(2); | ||
|
|
||
| } |
There was a problem hiding this comment.
The objective is to turn the code in Sprint-1/3-mandatory-interpret/3-to-pounds.js into a function.
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.