Skip to content

Sheffeld| May 2025| Mayowa Fadare| Structuring-and-testing-Sprint-2 #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mayowa0-7
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

My pull request about the module structure sprint 2,i went through the sprint and answered questions attached tot he sprint

Questions

Ask any questions you have for your reviewer.

@mayowa0-7 mayowa0-7 added the Needs Review Participant to add when requesting review label Jun 28, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this PR is not in the format you agreed to follow:
image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 4, 2025
@mayowa0-7 mayowa0-7 added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 8, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 8, 2025

Changes look good.

Can you update the PR title so that it matches the format specified in the Self-checklist?
image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jul 8, 2025
@mayowa0-7 mayowa0-7 changed the title Structure sprint 2 Sheffeld| May 2025| Mayowa Fadare| Jul 10, 2025
@mayowa0-7 mayowa0-7 changed the title Sheffeld| May 2025| Mayowa Fadare| Sheffeld| May 2025| Mayowa Fadare| Structuring-and-testing-Sprint-2 Jul 10, 2025
@mayowa0-7 mayowa0-7 added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jul 10, 2025
@cjyuan cjyuan added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jul 11, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Jul 11, 2025

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants