Sheffield | May-2025 | Declan Williams| Sprint-1 #496
Conversation
…onverted into a string so that .Slice can be used and produce no errors.
…ier is directly after a number. and changed the times to the right clock time.
…event errors related to number slicing
…nd calculations in time format code
…se behind the steps
CatchingKiyoko
added
📅 Sprint 1
LonMcGregor
added
Review in progress
There was a problem hiding this comment.
Instead of changing the pull request template text file, do you know where it would be better to place your PR comments so they show in the github UI?
There was a problem hiding this comment.
when i send in the pull request i can then edit it there before posting.
There was a problem hiding this comment.
Can you explain your choice for the changes you made in this file?
There was a problem hiding this comment.
I made these changes because you can't start a variable with a number and it throws an error.
and two the changes to the times inside the variables because a 12 hour clock can only go to "12.59" and then goes back to "1" but i have noticed that i made the error of making the 12 hour clock as "AM" when the 24 hour clock tells me its "PM" and not "AM".
There was a problem hiding this comment.
a) You have identified the lines where there are function calls. Are you sure there are only 3? How do you decide when something is a function call?
b) c) d) Good answer
e) Good detailed explanation!
There was a problem hiding this comment.
a) i did believe there was only 3 function calls as i was overlooking the function "number" and just thinking of the .replaceAll functions on lines 4 and 5 after going over it with the teacher during workshop. so the total of functions being called is 5 in total (on lines 4 and 5 there is two function calls in each line and then the last function being called is the console.log on line 10)
There was a problem hiding this comment.
a) How is the program calculating the number of hours in a film?
b) When you see the result of this code running, how do you see it?
c) d) good answer
e) How do you think your suggestion of movieDuration compares to the earlier movieLength - is it clear what is different between these?
f) Can you find any cases where the result might not look like what we typically expect when dealing with time formats?
LonMcGregor
added
Reviewed
CatchingKiyoko
added
Needs Review
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.