London | May-2025 | Reza Jahanimir | Sprint-1 #489

Reza-Jahanimir · 2025-06-07T11:47:05Z

Learners, PR Template

Self checklist

[x ] I have committed my files one by one, on purpose, and for a reason
[x ] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
[ x] I have tested my changes
[x ] My changes follow the style guide
[x ] My changes meet the requirements of this task

Changelist

I have completed the exercise I was asked for

Questions

Ask any questions you have for your reviewer.

…an we access methods

LonMcGregor

Hi! You used good git commits - making small specific changes with good commit messages.
Your responses to the exercises are good, but there are a few points you should have a look at more closely - I've left some comments in the relevant files.

LonMcGregor · 2025-06-19T09:05:11Z

Sprint-1/1-key-exercises/3-paths.js

Good solution, but can you see any places here where you could clean up the code style?

This looks much neater - especially having all the logs together

LonMcGregor · 2025-06-19T09:06:44Z

Sprint-1/1-key-exercises/4-random.js

You've identified correctly what each of the math operations is doing. Can you describe what the overall purpose of the line is? What will the output of num be?

Great explanation

LonMcGregor · 2025-06-19T09:08:33Z

Sprint-1/2-mandatory-errors/3.js

You are correct that .slice() is a string method. With that in mind, what changes could you make to this code to fix the problem?

This works in this case. Would this still work if the number was being passed as a parameter?

LonMcGregor · 2025-06-19T09:09:12Z

Sprint-1/2-mandatory-errors/4.js

Why are you talking about "Go" variable naming rules here?

LonMcGregor · 2025-06-19T09:12:22Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

a) You have found 2 function calls correctly, can you see any others?
b) You have found a fix for the problem - can you explain why the original line would not work?
c) good answer
d) Correct, the first 2 lines are declarations. Are those the only declarations in this code?
e) Good explanation of what the functions do. can you explain why we want to convert it into an integer?

Very good answers

LonMcGregor · 2025-06-19T09:16:28Z

Sprint-1/3-mandatory-interpret/2-time-format.js

Good answers for most of these.
e) The result will be a formatted string, but the question is asking if there might be a better name for it than simply "result" - can you think of one?

Good suggestions

LonMcGregor · 2025-06-19T09:21:01Z

Sprint-1/4-stretch-explore/chrome.md

Did you also try the alert function?

Are there any other possible values you could get from prompt? Think about what other interactions might the user have with the popup box.

Good work investigating these functions

LonMcGregor

Good work having another look at these exercises. You've figured it almost all out. I just have one question remaining for the file in Sprint-1/2-mandatory-errors/3.js.

LonMcGregor · 2025-06-20T08:29:08Z

Sprint-1/1-key-exercises/3-paths.js

This looks much neater - especially having all the logs together

LonMcGregor · 2025-06-20T08:29:45Z

Sprint-1/1-key-exercises/4-random.js

Great explanation

LonMcGregor · 2025-06-20T08:30:43Z

Sprint-1/2-mandatory-errors/3.js

This works in this case. Would this still work if the number was being passed as a parameter?

LonMcGregor · 2025-06-20T08:31:22Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

Very good answers

LonMcGregor · 2025-06-20T08:31:58Z

Sprint-1/3-mandatory-interpret/2-time-format.js

Good suggestions

LonMcGregor · 2025-06-20T08:32:24Z

Sprint-1/4-stretch-explore/chrome.md

Good work investigating these functions

LonMcGregor · 2025-06-20T11:05:17Z

@Reza-Jahanimir I was thinking more of how you might handle a general case with a number you wanted to slice. Imagine if you had a function with a number parameter:

function example(cardNumber){ ... }

You wouldn't be able to wrap the variable declaration in quotes, so what could you do to allow for slicing?

Reza-Jahanimir · 2025-06-22T12:03:16Z

We use a toString() method https://www.w3schools.com/jsref/jsref_tostring_string.asp

…

On Fri, 20 Jun 2025 at 12:05, LonMcGregor ***@***.***> wrote: *LonMcGregor* left a comment (CodeYourFuture/Module-Structuring-and-Testing-Data#489) <#489 (comment)> @Reza-Jahanimir <https://github.com/Reza-Jahanimir> I was thinking more of how you might handle a general case with a number you wanted to slice. Imagine if you had a function with a number parameter: function example(cardNumber){ ... } You wouldn't be able to wrap the variable declaration in quotes, so what could you do to allow for slicing? — Reply to this email directly, view it on GitHub <#489 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BRECIMCS4DO4SWTRTXJPBED3EPTIJAVCNFSM6AAAAAB6Z2CGDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJRGAYTAMZUGM> . You are receiving this because you were mentioned.Message ID: <CodeYourFuture/Module-Structuring-and-Testing-Data/pull/489/c2991010343@ github.com>

LonMcGregor · 2025-06-23T09:17:24Z

@Reza-Jahanimir Yes, good answer. This PR is complete. Well done on your work for this Sprint

Reza-Jahanimir added 4 commits June 7, 2025 12:36

tried to explain variable redeclaration

4537db5

leaned how to use string formatting

2c8408a

learned slice,lastIndexOf and how can we use them together for slice

e07fba5

explained num represents

b5673e8

Reza-Jahanimir added the Needs Review Participant to add when requesting review label Jun 7, 2025

Reza-Jahanimir added 11 commits June 7, 2025 13:34

make a comment

f946b02

understanding const and let

e7ba13d

understating how does system reads the coder

0def05a

string method

6421e9f

string methods

87d44eb

learn about Variable Naming Rules

259306e

answered the questions

be72b0d

answered the questions

b47e499

explained the code line by line

cf581dd

learned what is v8 and node.js

3999f62

a short view of object oriented languages. what is a object and how c…

d314a95

…an we access methods

Reza-Jahanimir added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Jun 12, 2025

LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jun 19, 2025

LonMcGregor reviewed Jun 19, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 19, 2025

Reza-Jahanimir added 6 commits June 19, 2025 11:49

cleaned up the code style

078e279

describe output, purpose

54f716e

change the number to a string

f7e6a17

answered all the questions

72c375f

changed the variable called result

1d85b48

try the alert function, possible values we get from prompt

73cc423

Reza-Jahanimir added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jun 19, 2025

LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Jun 20, 2025

LonMcGregor reviewed Jun 20, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 20, 2025

fixed the code

77b600c

Reza-Jahanimir added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Jun 20, 2025

use a toString()method

637cd50

LonMcGregor added Reviewed Volunteer to add when completing a review Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Jun 23, 2025

Reza-Jahanimir mentioned this pull request Jul 5, 2025

London | May-2025 | Structuring and testing data | Reza Jahanimir Reza-Jahanimir/My-Coursework-Planner#104

Open

Uh oh!

London | May-2025 | Reza Jahanimir | Sprint-1 #489

Are you sure you want to change the base?

London | May-2025 | Reza Jahanimir | Sprint-1 #489

Uh oh!

Conversation

Reza-Jahanimir commented Jun 7, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor commented Jun 20, 2025

Uh oh!

Reza-Jahanimir commented Jun 22, 2025 via email

Uh oh!

LonMcGregor commented Jun 23, 2025

Uh oh!

Uh oh!