London | ITP-May-2025 | Halyna Kozlovska | Module-Structuring-and-Testing-Data | Sprint-1 #458

halyna-k · 2025-05-28T16:53:00Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Added answers and explanations for JavaScript tasks
Fixed syntax errors and renamed variables for clarity
Explained arithmetic and string operations step-by-step
Described how alert and prompt work in the Chrome console
Clarified the use of console object and its methods

Questions

Ask any questions you have for your reviewer.

Edit comment to better describe assignment in line 3.

Add logic (create initials from first, middle, and last name) to generate and log initials.

Add logic to get dir and ext parts of file path

add random number generation between given min and max; add step-by-step comments; add console output;

comment out text to prevent SyntaxError

change 'const' declaration to 'let' to allow reassignment; log the updated value

fix ReferenceError by declaring variable before use

fix TypeError by converting number to string before slicing

fix SyntaxError by renaming variables starting with numbers

add answers to all questions; correct syntax error in replaceAll()

add answers to all questions; fix variable name for clarity

add step-by-step explanation comments

add explanation for alert and prompt functions in Chrome console

add explanation of console object and its methods in Chrome DevTools

Amundeep-Dhaliwal · 2025-06-13T15:41:40Z

Hello Halyna, hope you are well.

Thanks for submitting this sprint 1 course work for the structuring & testing data module.
I liked how you used multiple commits for this work and the description of the PR is nice & concise.

Have a few comments:

Amundeep-Dhaliwal · 2025-06-13T15:43:30Z

Sprint-1/1-key-exercises/4-random.js

+// 1. Math.random() generates a decimal between 0 (inclusive) and 1 (exclusive)
+// 2. Multiply by (maximum - minimum + 1) to scale to the desired range size
+// 3. Math.floor() rounds down to get an integer from 0 up to range size minus 1
+// 4. Adding minimum shifts the range so the lowest number is minimum, not zero
 const num = Math.floor(Math.random() * (maximum - minimum + 1)) + minimum;


Good explanation.
Extension question: what is the range of values that num can take?

@Amundeep-Dhaliwal Thank you for your comment.
The value of num is an integer within the range from minimum to maximum, including both ends.

Apologies, should have clarified.

What are the numeric values for the upper & lower limits for num?

@Amundeep-Dhaliwal The lowest value num will be minimum, and the highest - maximum, so minimum ≤ num ≤ maximum. This line of code creates a random integer in that range by scaling a decimal from Math.random(), rounding down, and adding minimum.

@Amundeep-Dhaliwal Did I answer your question?

Amundeep-Dhaliwal

This looks good Halyna, well done.

Amundeep-Dhaliwal · 2025-06-13T15:48:40Z

Sprint-1/2-mandatory-errors/4.js

+// Rename variables to valid identifiers because names cannot start with a number
+const ClockTime_12Hour = "08:53";


This is good practice for naming variables. It can be quite difficult sometimes!

In JS it is common to use camel case when naming variables e.g. Time12Hour. In python it is common to use snake case when naming variables time_12_hour. It is good practice not to mix the two.

@Amundeep-Dhaliwal Thank you. I agree and will keep this in mind for future naming.

Amundeep-Dhaliwal · 2025-06-13T15:53:16Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

 // e) Describe what the expression Number(carPrice.replaceAll(",","")) is doing - what is the purpose of this expression?
+
+// Firstly, carPrice.replaceAll(",", "") removes all commas from the string
+// Then Number(...) converts the resulting string into a number type so it can be used in arithmetic


These look good, thanks for the explanations.

Amundeep-Dhaliwal · 2025-06-13T15:57:52Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+// 1. The code correctly converts movieLength into hours, minutes, and seconds for positive values.
+// 2. It doesn’t handle zero or negative values properly—these cases need extra checks.
+// 3. Minutes and seconds may appear without leading zeros.
+// 4. To improve add validation to handle zero or negative inputs gracefully.


These answers are good, it is nice to see that you are thinking about the edge cases for the code.

Amundeep-Dhaliwal · 2025-06-13T16:08:12Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

 const pence = paddedPenceNumberString
  .substring(paddedPenceNumberString.length - 2)
  .padEnd(2, "0");

+// 6. Output the formatted price in pounds and pence
 console.log(`£${pounds}.${pence}`);


This activity looks good.

halyna-k · 2025-06-24T08:35:19Z

@Amundeep-Dhaliwal Do I need to change the status to "Needs Review"?

halyna-k added 15 commits May 28, 2025 15:38

Install initial dependency

e813147

Update 1-count.js

7691eb4

Edit comment to better describe assignment in line 3.

update 2-initials.js

049c5a2

Add logic (create initials from first, middle, and last name) to generate and log initials.

update 3-paths.js

aa5a115

Add logic to get dir and ext parts of file path

update 4-random.js

3d01dd4

add random number generation between given min and max; add step-by-step comments; add console output;

update 0.js

5886ee8

comment out text to prevent SyntaxError

update 1.js

839005d

change 'const' declaration to 'let' to allow reassignment; log the updated value

update 2.js

37219f6

fix ReferenceError by declaring variable before use

update 3.js

fa6a1f1

fix TypeError by converting number to string before slicing

update 4.js

cc72238

fix SyntaxError by renaming variables starting with numbers

update 1-percentage-change.js

5ea4fc8

add answers to all questions; correct syntax error in replaceAll()

update 2-time-format.js

39f256d

add answers to all questions; fix variable name for clarity

update 3-to-pounds.js

28cf27f

add step-by-step explanation comments

update chrome.md

189acd6

add explanation for alert and prompt functions in Chrome console

update objects.md

c0b40c6

add explanation of console object and its methods in Chrome DevTools

halyna-k added the Needs Review Participant to add when requesting review label May 28, 2025

halyna-k linked an issue May 28, 2025 that may be closed by this pull request

03 Complete Sprint 1 Coursework halyna-k/My-Coursework-Planner#44

Open

halyna-k mentioned this pull request May 28, 2025

Step 2 Submission halyna-k/My-Coursework-Planner#51

Open

halyna-k requested review from shieldo, cjyuan, suziebrown and Amundeep-Dhaliwal June 10, 2025 08:25

halyna-k added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Jun 13, 2025

Amundeep-Dhaliwal reviewed Jun 13, 2025

View reviewed changes

halyna-k requested a review from Amundeep-Dhaliwal June 13, 2025 16:02

Amundeep-Dhaliwal reviewed Jun 13, 2025

View reviewed changes

Amundeep-Dhaliwal added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jun 13, 2025

cjyuan removed their request for review June 13, 2025 17:16

halyna-k requested a review from Amundeep-Dhaliwal June 13, 2025 19:13

halyna-k added Needs Review Participant to add when requesting review Reviewed Volunteer to add when completing a review and removed Reviewed Volunteer to add when completing a review Needs Review Participant to add when requesting review labels Jun 15, 2025

MorganDavid added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jun 28, 2025

halyna-k mentioned this pull request Jul 8, 2025

Step 3 Submission halyna-k/My-Coursework-Planner#110

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

London | ITP-May-2025 | Halyna Kozlovska | Module-Structuring-and-Testing-Data | Sprint-1 #458

London | ITP-May-2025 | Halyna Kozlovska | Module-Structuring-and-Testing-Data | Sprint-1 #458

Uh oh!

halyna-k commented May 28, 2025 •

edited

Loading

Uh oh!

Amundeep-Dhaliwal commented Jun 13, 2025

Uh oh!

Amundeep-Dhaliwal Jun 13, 2025

Uh oh!

halyna-k Jun 13, 2025 •

edited

Loading

Uh oh!

Amundeep-Dhaliwal Jun 13, 2025

Uh oh!

halyna-k Jun 13, 2025

Uh oh!

halyna-k Jun 18, 2025

Uh oh!

Amundeep-Dhaliwal left a comment

Uh oh!

Amundeep-Dhaliwal Jun 13, 2025

Uh oh!

halyna-k Jun 13, 2025

Uh oh!

Amundeep-Dhaliwal Jun 13, 2025

Uh oh!

Amundeep-Dhaliwal Jun 13, 2025

Uh oh!

Amundeep-Dhaliwal Jun 13, 2025

Uh oh!

halyna-k commented Jun 24, 2025

Uh oh!

Uh oh!

		// Rename variables to valid identifiers because names cannot start with a number
		const ClockTime_12Hour = "08:53";

Uh oh!

London | ITP-May-2025 | Halyna Kozlovska | Module-Structuring-and-Testing-Data | Sprint-1 #458

Are you sure you want to change the base?

London | ITP-May-2025 | Halyna Kozlovska | Module-Structuring-and-Testing-Data | Sprint-1 #458

Uh oh!

Conversation

halyna-k commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

Amundeep-Dhaliwal commented Jun 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

halyna-k Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amundeep-Dhaliwal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

halyna-k commented Jun 24, 2025

Uh oh!

Uh oh!

halyna-k commented May 28, 2025 •

edited

Loading

halyna-k Jun 13, 2025 •

edited

Loading