Skip to content

WM | ITP-Jan25 | Hatef Eidi | Module Strcturing and Testing Data | Sprint-1 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

HatefEidi
Copy link

Learners, PR Template

Self checklist

  • [* ] I have committed my files one by one, on purpose, and for a reason
  • [ *] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ *] I have tested my changes
  • [ *] My changes follow the style guide
  • [ *] My changes meet the requirements of this task

Changelist

Briefly explain your PR.
The Solution to Module Structuring and Testing Data, Sprint-1

Questions

Ask any questions you have for your reviewer.

Thanks for your time reviewing my Solutions.

@HatefEidi HatefEidi added Needs Review Participant to add when requesting review 📅 Sprint 1 Assigned during Sprint 1 of this module labels Feb 7, 2025
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 17, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.
I only have a few comments and suggestions.

What is the return value of `prompt`?
The input of the what is your name pop-up text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you were writing a program that uses prompt() to ask for an input value, how can
your program tell if the user clicked "OK" or "Cancel"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they press cancel, whether or not they have entered their name in the text box- in the console we will see the 'null' in the next line of the prompt
If they enter their name, and press ok, in the console they can view their name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user entered "null" and pressed ok?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will return the string of null which is the input=> 'null'

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 17, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Feb 18, 2025

Looks good. Feel free to mark this PR as completed.

@HatefEidi HatefEidi added Complete Volunteer to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants