-
-
Notifications
You must be signed in to change notification settings - Fork 195
WM | ITP-Jan25 | Hatef Eidi | Module Strcturing and Testing Data | Sprint-1 #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
I only have a few comments and suggestions.
What is the return value of `prompt`? | ||
The input of the what is your name pop-up text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you were writing a program that uses prompt()
to ask for an input value, how can
your program tell if the user clicked "OK" or "Cancel"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they press cancel, whether or not they have entered their name in the text box- in the console we will see the 'null' in the next line of the prompt
If they enter their name, and press ok, in the console they can view their name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the user entered "null" and pressed ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will return the string of null which is the input=> 'null'
Looks good. Feel free to mark this PR as completed. |
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
The Solution to Module Structuring and Testing Data, Sprint-1
Questions
Ask any questions you have for your reviewer.
Thanks for your time reviewing my Solutions.