Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

West Midlands | Alireza Seifi Shalamzari | Module-Data-Groups | Week 3 #290

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

West Midlands | Alireza Seifi Shalamzari | Module-Data-Groups | Week 3 #290

wants to merge 6 commits into from

Conversation

Alireza1620
Copy link

@Alireza1620 Alireza1620 commented Jan 15, 2025 •
edited
Loading

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

This PR is the completed version of Quote generator app

Questions

Ask any questions you have for your reviewer.

@Alireza1620 Alireza1620 added the Needs Review Participant to add when requesting review label Jan 15, 2025
@Alireza1620 Alireza1620 mentioned this pull request Jan 15, 2025
Closed
3 tasks
cjyuan
cjyuan reviewed Jan 17, 2025
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Feel free to mark this PR as Completed.

Suggestion:
We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a good reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 17, 2025
@Alireza1620 Alireza1620 added the Complete Participant to add when work is complete and review comments have been addressed label Jan 17, 2025
@Alireza1620
Copy link
Author

Code looks good. Feel free to mark this PR as Completed.

Suggestion: We should respect instructions like DO NOT EDIT BELOW HERE; it is usually there for a good reason. If you are curious about why, you can ask ChatGPT Why should programmers respect "DO NOT EDIT BELOW HERE" instruction in a file?

Thanks for your comment, I thought it would be great if I can customise it with my own ideas! I won't change it further for sure....XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

@eliza-an eliza-an Awaiting requested review from eliza-an

@KudahShambare KudahShambare Awaiting requested review from KudahShambare

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alireza1620 @cjyuan