Adjust Git Status Parsing to Better Handle Null Chars #2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with git status parsing where the substring indexing was off-by-one when creating the file string due to an index being incremented before creating a substring.
Fixes this by incrementing the current string index after returning the correct substring.
The related issue is marked as a Tahoe bug, the Tahoe bug is that Tahoe now shows the null character as a %00 at the end of the label, where previous macOS versions did not. This change is retroactive however as it is a bug fix.
Related Issues
Checklist
Screenshots
N/A