Add Support for Xcode 14.3's ENABLE_MODULE_VERIFIER #12390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module verifier validates framework modularity in a clean test environment that doesn't work out of the box with the way CocoaPods framework targets are installed in CONFIGURATION_BUILD_DIR. Specifically, Xcode's default behaviour is to build framework bundles directly in $(CONFIGURATION_BUILD_DIR), whereas pod framework targets are built in a nested directory $(PODS_CONFIGURATION_BUILD_DIR)/PodName/. The result is that any Xcode framework target with ENABLE_MODULE_VERIFIER set to YES will fail to locate pod framework headers when verifying modularity. By customizing OTHER_MODULE_VERIFIER_FLAGS, we can add pod framework build directories to the framework search path, allowing Xcode framework targets that depend on pod framework targets to use the module verifier.
Here's an example of your CHANGELOG entry: * Add Support for Xcode 14.3's ENABLE_MODULE_VERIFIER
[sharplet](https://github.com/sharplet)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module verifier validates framework modularity in a clean test environment that doesn't work out of the box with the way CocoaPods framework targets are installed in
CONFIGURATION_BUILD_DIR. Specifically, Xcode's default behaviour is to build framework bundles directly in$(CONFIGURATION_BUILD_DIR), whereas pod framework targets are built in a nested directory$(PODS_CONFIGURATION_BUILD_DIR)/PodName/. The result is that any Xcode framework target withENABLE_MODULE_VERIFIERset toYESwill fail to locate pod framework headers when verifying modularity.By customizing
OTHER_MODULE_VERIFIER_FLAGS, we can add pod framework build directories to the framework search path, allowing Xcode framework targets that depend on pod framework targets to use the module verifier.